Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 810563008: (Temporarily) disable -Wl,-z,defs when using sanitizers (Closed)

Created:
5 years, 11 months ago by jamesr
Modified:
5 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Temporarily) disable -Wl,-z,defs when using sanitizers Compiling with -Wl,-z,defs and asan requires declaring a dependency on //build/config/sanitizers:deps in every shared_library and executable, however piles and piles of targets do not do this yet so this flag busts the asan/etc builds in GN. Disable for now so we can add the dependencies bit by bit. R=thakis@chromium.org BUG=371125 Committed: https://crrev.com/2eff74b542c9dceb330967c7fa06274a4addf443 Cr-Commit-Position: refs/heads/master@{#312543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
This is unfortunate but I think the best option here (this showed up on the ...
5 years, 11 months ago (2015-01-22 01:57:22 UTC) #1
Nico
On 2015/01/22 01:57:22, jamesr wrote: > This is unfortunate but I think the best option ...
5 years, 11 months ago (2015-01-22 02:03:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810563008/1
5 years, 11 months ago (2015-01-22 02:05:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 02:49:52 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:50:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2eff74b542c9dceb330967c7fa06274a4addf443
Cr-Commit-Position: refs/heads/master@{#312543}

Powered by Google App Engine
This is Rietveld 408576698