Add POST support to XHR as well as .status and statusText support

Add POST support to XHR as well as .status and statusText support

Also fixed all the XHR tests to actually run and work
I learned from elliot that the it function has to
take a "done" argument to be treated asynchronously.

My utf8 conversion is a hack, but we deleted
window.TextEncoder (it was a module) when we forked.
We could resurrect TextEncoder (and probably should)
but I've left that for a separate change.

I also augmented sky_server to have a special /echo_post
handler so we can test POST requests.

R=esprehn@chromium.org
BUG=

Committed: https://chromium.googlesource.com/external/mojo/+/5ef81d249b841f44c9593ffb0158d64c7e0febfc

Committed: https://chromium.googlesource.com/external/mojo/+/6a2cfe9b98e9ecebef3508f5eb8258f942b7af29

[eseidel, 2014-12-15 21:31:52]

CCing matt in case he's curious to see our use of the mojo network upload apis.

[esprehn, 2014-12-15 21:43:23]

https://codereview.chromium.org/810523002/diff/1/sky/framework/xmlhttprequest...
File sky/framework/xmlhttprequest.sky (right):

https://codereview.chromium.org/810523002/diff/1/sky/framework/xmlhttprequest...
sky/framework/xmlhttprequest.sky:30: uintArray.push(charList[i].charCodeAt(0));
This doesn't make sense, the splitting above seems to be trying to deal with
multi part unicode points, but charCodeAt will only ever return one part anyway.
You either want to use codePointAt() or just iterate the string here.

The unescape(encodeURIComponent trick is also weird, not sure what this is
doing. I don't think you need it.

https://codereview.chromium.org/810523002/diff/1/sky/tests/framework/xmlhttpr...
File sky/tests/framework/xmlhttprequest/xhr-does-not-exist.sky (right):

https://codereview.chromium.org/810523002/diff/1/sky/tests/framework/xmlhttpr...
sky/tests/framework/xmlhttprequest/xhr-does-not-exist.sky:17:
assert.equal(xhr.status, 404, "status is 404");
You don't actually need the third argument with the string.

[esprehn, 2014-12-15 21:50:56]

https://codereview.chromium.org/810523002/diff/1/sky/framework/xmlhttprequest...
File sky/framework/xmlhttprequest.sky (right):

https://codereview.chromium.org/810523002/diff/1/sky/framework/xmlhttprequest...
sky/framework/xmlhttprequest.sky:30: uintArray.push(charList[i].charCodeAt(0));
On 2014/12/15 at 21:43:22, esprehn wrote:
> This doesn't make sense, the splitting above seems to be trying to deal with
multi part unicode points, but charCodeAt will only ever return one part anyway.
You either want to use codePointAt() or just iterate the string here.
> 
> The unescape(encodeURIComponent trick is also weird, not sure what this is
doing. I don't think you need it.

I think you want:

function stringToUTF8Buffer(string) {
    var buffer = new Uint8Array(string.length);
    for (var i = 0; i < string.length; i++) {
        buffer[i] = string.charCodeAt(i);
    }
    return buffer;
}

I think you use charCodeAt() since it's a uint8 array, so we need to split the
multi part unicode chars.

[eseidel, 2014-12-15 22:11:11]

On 2014/12/15 21:50:56, esprehn wrote:
>
https://codereview.chromium.org/810523002/diff/1/sky/framework/xmlhttprequest...
> File sky/framework/xmlhttprequest.sky (right):
> 
>
https://codereview.chromium.org/810523002/diff/1/sky/framework/xmlhttprequest...
> sky/framework/xmlhttprequest.sky:30:
uintArray.push(charList[i].charCodeAt(0));
> On 2014/12/15 at 21:43:22, esprehn wrote:
> > This doesn't make sense, the splitting above seems to be trying to deal with
> multi part unicode points, but charCodeAt will only ever return one part
anyway.
> You either want to use codePointAt() or just iterate the string here.
> > 
> > The unescape(encodeURIComponent trick is also weird, not sure what this is
> doing. I don't think you need it.
> 
> I think you want:
> 
> function stringToUTF8Buffer(string) {
>     var buffer = new Uint8Array(string.length);
>     for (var i = 0; i < string.length; i++) {
>         buffer[i] = string.charCodeAt(i);
>     }
>     return buffer;
> }
> 
> I think you use charCodeAt() since it's a uint8 array, so we need to split the
> multi part unicode chars.

I tried that version and it cause my test to fail:
 1ERROR: Uncaught AssertionError: expected '#F\' B\'/1 9DI #CD \'D2,\', H G0\'
D\' J$DEFJ.' to equal 'أنا قادر على أكل الزجاج و هذا لا يؤلمني.'

[esprehn, 2014-12-16 00:08:20]

lgtm

[eseidel, 2014-12-16 00:09:55]

Committed patchset #2 (id:20001) manually as
5ef81d249b841f44c9593ffb0158d64c7e0febfc (presubmit successful).

[eseidel, 2014-12-16 19:20:45]

Committed patchset #2 (id:20001) manually as
6a2cfe9b98e9ecebef3508f5eb8258f942b7af29 (presubmit successful).