Issue 810513002: Look at DYNAMIC_ANNOTATIONS_ENABLED now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 810513002: Look at DYNAMIC_ANNOTATIONS_ENABLED now. (Closed)

Created:
6 years ago by mtklein_C

Modified:
6 years ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Look at DYNAMIC_ANNOTATIONS_ENABLED now. Defining SK_DYNAMIC_ANNOTATIONS_ENABLED as 1 whenever DYNAMIC_ANNOTATIONS_ENABLED was 1 seems to be working fine for Chrome. Should be we can just use DYNAMIC_ANNOTATIONS_ENABLED. BUG=skia: Committed: https://skia.googlesource.com/skia/+/0faaac64187a1cb811b03d48be3e6d2e24a799c1

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	gyp/common_conditions.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	include/core/SkDynamicAnnotations.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810513002/1

6 years ago (2014-12-15 21:26:52 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-15 21:38:14 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0faaac64187a1cb811b03d48be3e6d2e24a799c1

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages