Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Side by Side Diff: ui/file_manager/video_player/js/background.js

Issue 810483005: [Video Player] Remove the default id of the video player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * Icon of the video player. 6 * Icon of the video player.
7 * TODO(yoshiki): Consider providing an exact size icon, instead of relying 7 * TODO(yoshiki): Consider providing an exact size icon, instead of relying
8 * on downsampling by ash. 8 * on downsampling by ash.
9 * 9 *
10 * @type {string} 10 * @type {string}
11 * @const 11 * @const
12 */ 12 */
13 var ICON_IMAGE = 'images/icon/video-player-64.png'; 13 var ICON_IMAGE = 'images/icon/video-player-64.png';
14 14
15 /** 15 /**
16 * Configuration of the video player panel. 16 * Configuration of the video player panel.
17 * @type {Object} 17 * @type {Object}
18 */ 18 */
19 var windowCreateOptions = { 19 var windowCreateOptions = {
20 id: 'video',
21 frame: 'none', 20 frame: 'none',
22 minWidth: 480, 21 minWidth: 480,
23 minHeight: 270 22 minHeight: 270
24 }; 23 };
25 24
26 /** 25 /**
27 * Backgound object. This is necessary for AppWindowWrapper. 26 * Backgound object. This is necessary for AppWindowWrapper.
28 * @type {BackgroundBase} 27 * @type {BackgroundBase}
29 */ 28 */
30 var background = new BackgroundBase(); 29 var background = new BackgroundBase();
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 133
135 videoPlayer.setIcon(ICON_IMAGE); 134 videoPlayer.setIcon(ICON_IMAGE);
136 AppWindowWrapper.focusOnDesktop(appWindow); 135 AppWindowWrapper.focusOnDesktop(appWindow);
137 136
138 return windowId; 137 return windowId;
139 }.wrap()).catch(function(error) { 138 }.wrap()).catch(function(error) {
140 console.error('Launch failed' + error.stack || error); 139 console.error('Launch failed' + error.stack || error);
141 return Promise.reject(error); 140 return Promise.reject(error);
142 }.wrap()); 141 }.wrap());
143 } 142 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698