Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 810433003: Revert of base: Fix DiscardableSharedMemory::mapped_size(). (Closed)

Created:
5 years, 11 months ago by pennymac
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Fix DiscardableSharedMemory::mapped_size(). (patchset #2 id:20001 of https://codereview.chromium.org/842003002/) Reason for revert: Reverting this 2nd CL that touches discardable_shared_memory. High levels of Windows crashes resulted from something in one of these two CLs (https://codereview.chromium.org/793443003 is the other). Ref: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome%27%20AND%20product.version%3D%2741.0.2271.0%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27renderer%27 Original issue's description: > base: Fix DiscardableSharedMemory::mapped_size(). > > Set |mapped_size_| to 0 after unmapping memory. > > BUG=429416 > TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.MappedSize > > Committed: https://crrev.com/95bc5b1779dcf8e4a9e37ef600c0ea76293307e3 > Cr-Commit-Position: refs/heads/master@{#310625} TBR=danakj@chromium.org,avi@chromium.org,reveman@chromium.org NOTREECHECKS=true NOTRY=true BUG=429416 Committed: https://crrev.com/86a0ec0ecfbdb49472e73fa365cf41372732e359 Cr-Commit-Position: refs/heads/master@{#310916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M base/memory/discardable_shared_memory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/discardable_shared_memory_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
pennymac
Created Revert of base: Fix DiscardableSharedMemory::mapped_size().
5 years, 11 months ago (2015-01-10 00:24:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810433003/1
5 years, 11 months ago (2015-01-10 00:25:15 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-10 00:25:17 UTC) #4
danakj
FWIW I don't think you need this. If it's turned off, this shouldn't matter.
5 years, 11 months ago (2015-01-10 00:28:24 UTC) #5
danakj
On 2015/01/10 00:28:24, danakj wrote: > FWIW I don't think you need this. If it's ...
5 years, 11 months ago (2015-01-10 00:28:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810433003/1
5 years, 11 months ago (2015-01-10 00:30:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-10 00:32:04 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-10 00:33:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86a0ec0ecfbdb49472e73fa365cf41372732e359
Cr-Commit-Position: refs/heads/master@{#310916}

Powered by Google App Engine
This is Rietveld 408576698