Issue 81043002: Code object now prints its major_key when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 81043002: Code object now prints its major_key when applicable. (Closed)

Created:
7 years, 1 month ago by Igor Sheludko

Modified:
7 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Code object now prints its major_key when applicable. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17980

Patch Set 2 : Identation fixed. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -21 lines)			Patch
M	src/objects.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View		2 chunks	+17 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://codereview.chromium.org/81043002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/81043002/diff/1/src/objects.cc#newcode11141 src/objects.cc:11141: CodeStub::MajorName(CodeStub::GetMajorKey(this), true)); nit: indentation (align ...

7 years, 1 month ago (2013-11-21 15:52:13 UTC) #2

Igor Sheludko

https://codereview.chromium.org/81043002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/81043002/diff/1/src/objects.cc#newcode11141 src/objects.cc:11141: CodeStub::MajorName(CodeStub::GetMajorKey(this), true)); On 2013/11/21 15:52:14, Jakob wrote: > nit: ...

7 years, 1 month ago (2013-11-21 16:54:58 UTC) #3

Igor Sheludko

7 years, 1 month ago (2013-11-21 16:55:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r17980 (presubmit successful).

Expand Messages | Collapse Messages

Issue 81043002: Code object now prints its major_key when applicable. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Identation fixed. #

Messages