Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: storage/browser/blob/blob_url_request_job_factory.h

Issue 810403004: [Storage] Blob Storage Refactoring pt 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: memory leak fixed Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/blob_url_request_job_factory.h
diff --git a/storage/browser/blob/blob_url_request_job_factory.h b/storage/browser/blob/blob_url_request_job_factory.h
index c3e34e38b6777e6375be19ac2a7916f70945ad6d..493a31eb54108a7d8a7f1dc90f46df3337d0c990 100644
--- a/storage/browser/blob/blob_url_request_job_factory.h
+++ b/storage/browser/blob/blob_url_request_job_factory.h
@@ -26,8 +26,8 @@ class URLRequestContext;
namespace storage {
-class BlobData;
-class BlobDataHandle;
+class BlobDataSnapshot;
+class BlobDataSnapshotHandle;
class BlobStorageContext;
class STORAGE_EXPORT BlobProtocolHandler
@@ -35,7 +35,7 @@ class STORAGE_EXPORT BlobProtocolHandler
public:
// A helper to manufacture an URLRequest to retrieve the given blob.
static scoped_ptr<net::URLRequest> CreateBlobRequest(
- scoped_ptr<BlobDataHandle> blob_data_handle,
+ scoped_ptr<BlobDataSnapshotHandle> blob_data_handle,
const net::URLRequestContext* request_context,
net::URLRequest::Delegate* request_delegate);
@@ -43,7 +43,7 @@ class STORAGE_EXPORT BlobProtocolHandler
// to SetRequestedBlobDataHandle instead.
static void SetRequestedBlobDataHandle(
net::URLRequest* request,
- scoped_ptr<BlobDataHandle> blob_data_handle);
+ scoped_ptr<BlobDataSnapshotHandle> blob_data_handle);
BlobProtocolHandler(
BlobStorageContext* context,
@@ -56,8 +56,7 @@ class STORAGE_EXPORT BlobProtocolHandler
net::NetworkDelegate* network_delegate) const override;
private:
- scoped_refptr<BlobData> LookupBlobData(
- net::URLRequest* request) const;
+ const BlobDataSnapshot* LookupBlobData(net::URLRequest* request) const;
base::WeakPtr<BlobStorageContext> context_;
const scoped_refptr<storage::FileSystemContext> file_system_context_;

Powered by Google App Engine
This is Rietveld 408576698