[Storage] Blob Storage Refactoring pt 1

content/browser/fileapi/chrome_blob_storage_context.cc

Index: content/browser/fileapi/chrome_blob_storage_context.cc
diff --git a/content/browser/fileapi/chrome_blob_storage_context.cc b/content/browser/fileapi/chrome_blob_storage_context.cc
index f085242f689eab0c8f37a6079d4ae9664fdc946a..121a54fa14f1a822e726911a0e6e4c2e69d94471 100644
--- a/content/browser/fileapi/chrome_blob_storage_context.cc
+++ b/content/browser/fileapi/chrome_blob_storage_context.cc
@@ -23,16 +23,15 @@ const char kBlobStorageContextKeyName[] = "content_blob_storage_context";
 
 class BlobHandleImpl : public BlobHandle {
  public:
-  explicit BlobHandleImpl(scoped_ptr<storage::BlobDataHandle> handle)
-      : handle_(handle.Pass()) {
-  }
+  explicit BlobHandleImpl(scoped_ptr<storage::BlobDataSnapshotHandle> handle)
+      : handle_(handle.Pass()) {}
 
   ~BlobHandleImpl() override {}
 
   std::string GetUUID() override { return handle_->uuid(); }
 
  private:
-  scoped_ptr<storage::BlobDataHandle> handle_;
+  scoped_ptr<storage::BlobDataSnapshotHandle> handle_;

[michaeln, 2015/01/16 00:09:09]

for this particular class we only want to keep the uuid around, we want to allow
the snapshot can to change out from underneath

[dmurph, 2015/01/16 23:45:56]

Right, we want to keep the handle around though, right?

 };
 
 }  // namespace
@@ -69,11 +68,12 @@ scoped_ptr<BlobHandle> ChromeBlobStorageContext::CreateMemoryBackedBlob(
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   std::string uuid(base::GenerateGUID());
-  scoped_refptr<storage::BlobData> blob_data = new storage::BlobData(uuid);
+  scoped_ptr<storage::BlobDataBuilder> blob_data(
+      new storage::BlobDataBuilder(uuid));
   blob_data->AppendData(data, length);
 
-  scoped_ptr<storage::BlobDataHandle> blob_data_handle =
-      context_->AddFinishedBlob(blob_data.get());
+  scoped_ptr<storage::BlobDataSnapshotHandle> blob_data_handle =
+      context_->AddFinishedBlob(*blob_data.get());
   if (!blob_data_handle)
     return scoped_ptr<BlobHandle>();