chrome/browser/sync_file_system/local/canned_syncable_file_system.cc - Issue 810403004: [Storage] Blob Storage Refactoring pt 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/canned_syncable_file_system.cc

Issue 810403004: [Storage] Blob Storage Refactoring pt 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: memory leak fixed Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/local/canned_syncable_file_system.h ('k') | content/browser/fileapi/blob_storage_context_unittest.cc » ('j') | content/browser/fileapi/blob_storage_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/canned_syncable_file_system.cc

diff --git a/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc b/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc

index c636e35ed25b8f472e0d61777ddcfc5bb7830bcf..14f3e63799ec961dea05ad4d92d5698a1aaff3e8 100644

--- a/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc

+++ b/chrome/browser/sync_file_system/local/canned_syncable_file_system.cc

@@ -469,7 +469,7 @@ File::Error CannedSyncableFileSystem::ReadDirectory(

int64 CannedSyncableFileSystem::Write(

net::URLRequestContext* url_request_context,

const FileSystemURL& url,

- scoped_ptr<storage::BlobDataHandle> blob_data_handle) {

+ scoped_ptr<storage::BlobDataSnapshotHandle> blob_data_handle) {

return RunOnThread<int64>(io_task_runner_.get(),

FROM_HERE,

base::Bind(&CannedSyncableFileSystem::DoWrite,

@@ -687,7 +687,7 @@ void CannedSyncableFileSystem::DoReadDirectory(

void CannedSyncableFileSystem::DoWrite(

net::URLRequestContext* url_request_context,

const FileSystemURL& url,

- scoped_ptr<storage::BlobDataHandle> blob_data_handle,

+ scoped_ptr<storage::BlobDataSnapshotHandle> blob_data_handle,

const WriteCallback& callback) {

EXPECT_TRUE(io_task_runner_->RunsTasksOnCurrentThread());

EXPECT_TRUE(is_filesystem_opened_);