Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: storage/browser/blob/blob_data_handle.cc

Issue 810403004: [Storage] Blob Storage Refactoring pt 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed copyright Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "storage/browser/blob/blob_data_handle.h" 5 #include "storage/browser/blob/blob_data_handle.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
11 #include "storage/browser/blob/blob_data_snapshot.h"
11 #include "storage/browser/blob/blob_storage_context.h" 12 #include "storage/browser/blob/blob_storage_context.h"
12 #include "storage/common/blob/blob_data.h"
13 13
14 namespace storage { 14 namespace storage {
15 15
16 BlobDataHandle::BlobDataHandleShared::BlobDataHandleShared( 16 BlobDataHandle::BlobDataHandleShared::BlobDataHandleShared(
17 BlobData* blob_data, 17 const std::string& uuid,
18 BlobStorageContext* context, 18 BlobStorageContext* context,
19 base::SequencedTaskRunner* task_runner) 19 base::SequencedTaskRunner* task_runner)
20 : blob_data_(blob_data), 20 : uuid_(uuid), context_(context->AsWeakPtr()) {
21 context_(context->AsWeakPtr()) { 21 context_->IncrementBlobRefCount(uuid);
22 context_->IncrementBlobRefCount(blob_data->uuid());
23 } 22 }
24 23
25 BlobData* BlobDataHandle::BlobDataHandleShared::data() const { 24 scoped_ptr<BlobDataSnapshot>
26 return blob_data_.get(); 25 BlobDataHandle::BlobDataHandleShared::CreateSnapshot() const {
26 return context_->CreateSnapshot(uuid_).Pass();
27 } 27 }
28 28
29 const std::string& BlobDataHandle::BlobDataHandleShared::uuid() const { 29 const std::string& BlobDataHandle::BlobDataHandleShared::uuid() const {
30 return blob_data_->uuid(); 30 return uuid_;
31 } 31 }
32 32
33 BlobDataHandle::BlobDataHandleShared::~BlobDataHandleShared() { 33 BlobDataHandle::BlobDataHandleShared::~BlobDataHandleShared() {
34 if (context_.get()) 34 if (context_.get())
35 context_->DecrementBlobRefCount(blob_data_->uuid()); 35 context_->DecrementBlobRefCount(uuid_);
36 } 36 }
37 37
38 BlobDataHandle::BlobDataHandle(BlobData* blob_data, 38 BlobDataHandle::BlobDataHandle(const std::string& uuid,
39 BlobStorageContext* context, 39 BlobStorageContext* context,
40 base::SequencedTaskRunner* task_runner) 40 base::SequencedTaskRunner* task_runner)
41 : io_task_runner_(task_runner), 41 : io_task_runner_(task_runner),
42 shared_(new BlobDataHandleShared(blob_data, context, task_runner)) { 42 shared_(new BlobDataHandleShared(uuid, context, task_runner)) {
43 DCHECK(io_task_runner_.get()); 43 DCHECK(io_task_runner_.get());
44 DCHECK(io_task_runner_->RunsTasksOnCurrentThread()); 44 DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
45 } 45 }
46 46
47 BlobDataHandle::BlobDataHandle(const BlobDataHandle& other) { 47 BlobDataHandle::BlobDataHandle(const BlobDataHandle& other) {
48 io_task_runner_ = other.io_task_runner_; 48 io_task_runner_ = other.io_task_runner_;
49 shared_ = other.shared_; 49 shared_ = other.shared_;
50 } 50 }
51 51
52 BlobDataHandle::~BlobDataHandle() { 52 BlobDataHandle::~BlobDataHandle() {
53 BlobDataHandleShared* raw = shared_.get(); 53 BlobDataHandleShared* raw = shared_.get();
54 raw->AddRef(); 54 raw->AddRef();
55 shared_ = 0; 55 shared_ = nullptr;
56 io_task_runner_->ReleaseSoon(FROM_HERE, raw); 56 io_task_runner_->ReleaseSoon(FROM_HERE, raw);
57 } 57 }
58 58
59 BlobData* BlobDataHandle::data() const { 59 scoped_ptr<BlobDataSnapshot> BlobDataHandle::CreateSnapshot() const {
60 DCHECK(io_task_runner_->RunsTasksOnCurrentThread()); 60 DCHECK(io_task_runner_->RunsTasksOnCurrentThread());
61 return shared_->data(); 61 return shared_->CreateSnapshot().Pass();
62 } 62 }
63 63
64 std::string BlobDataHandle::uuid() const { 64 const std::string& BlobDataHandle::uuid() const {
65 return shared_->uuid(); 65 return shared_->uuid();
66 } 66 }
67 67
68 } // namespace storage 68 } // namespace storage
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698