[Storage] Blob Storage Refactoring pt 1

content/browser/indexed_db/indexed_db_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_dispatcher_host.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/guid.h"
@@ skipping 208 matching lines @@
 }
 
 std::string IndexedDBDispatcherHost::HoldBlobData(
     const IndexedDBBlobInfo& blob_info) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   std::string uuid = blob_info.uuid();
   storage::BlobStorageContext* context = blob_storage_context_->context();
   scoped_ptr<storage::BlobDataHandle> blob_data_handle;
   if (uuid.empty()) {
     uuid = base::GenerateGUID();
-    scoped_refptr<storage::BlobData> blob_data = new storage::BlobData(uuid);
+    scoped_ptr<storage::BlobDataBuilder> blob_data(

[michaeln, 2015/01/21 01:46:41]

instead of heap allocaing it, could BlobDataBuilder be sitting on the stack?

[dmurph, 2015/01/21 22:40:11]

Done.

+        new storage::BlobDataBuilder(uuid));
     blob_data->set_content_type(base::UTF16ToUTF8(blob_info.type()));
     blob_data->AppendFile(blob_info.file_path(), 0, blob_info.size(),
                           blob_info.last_modified());
-    blob_data_handle = context->AddFinishedBlob(blob_data.get());
+    blob_data_handle = context->AddFinishedBlob(*blob_data.get());

[michaeln, 2015/01/21 01:46:41]

so readers don't have to decrypt *smart.get() 

[dmurph, 2015/01/21 22:40:11]

Done.

   } else {
     auto iter = blob_data_handle_map_.find(uuid);
     if (iter != blob_data_handle_map_.end()) {
       iter->second.second += 1;
       return uuid;
     }
     blob_data_handle = context->GetBlobDataFromUUID(uuid);
   }
 
   DCHECK(!ContainsKey(blob_data_handle_map_, uuid));
@@ skipping 777 matching lines @@
 }
 
 void IndexedDBDispatcherHost::CursorDispatcherHost::OnDestroyed(
     int32 ipc_object_id) {
   DCHECK(
       parent_->indexed_db_context_->TaskRunner()->RunsTasksOnCurrentThread());
   parent_->DestroyObject(&map_, ipc_object_id);
 }
 
 }  // namespace content