Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 810403003: [turbofan] remove checks for virtual register overflow (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] remove checks for virtual register overflow R=bmeurer@chromium.org BUG= Committed: https://crrev.com/b2378c7404e91d803d3ba136dfab952c7e83d313 Cr-Commit-Position: refs/heads/master@{#25968}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -78 lines) Patch
M src/compiler/instruction.h View 1 2 3 4 5 7 chunks +33 lines, -32 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/compiler/register-allocator.h View 3 chunks +1 line, -14 lines 0 comments Download
M src/compiler/register-allocator.cc View 14 chunks +1 line, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
https://codereview.chromium.org/810403003/diff/80001/src/compiler/instruction.h File src/compiler/instruction.h (right): https://codereview.chromium.org/810403003/diff/80001/src/compiler/instruction.h#newcode258 src/compiler/instruction.h:258: int virtual_register() const { return virtual_register_; } Can't we ...
5 years, 11 months ago (2015-01-07 11:24:08 UTC) #2
Benedikt Meurer
LGTM
5 years, 11 months ago (2015-01-07 11:33:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810403003/100001
5 years, 11 months ago (2015-01-07 11:33:26 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-07 12:00:45 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 12:01:00 UTC) #7
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/b2378c7404e91d803d3ba136dfab952c7e83d313
Cr-Commit-Position: refs/heads/master@{#25968}

Powered by Google App Engine
This is Rietveld 408576698