Regexp caching

src/compilation-cache.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 24 matching lines @@
 // scripts and evals. The boilerplates are looked up using the source
 // string as the key.
 class CompilationCache {
  public:
   // The same source code string has different compiled code for
   // scripts and evals. Internally, we use separate caches to avoid
   // getting the wrong kind of entry when looking up.
   enum Entry {
     SCRIPT,
     EVAL_GLOBAL,
-    EVAL_CONTEXTUAL
+    EVAL_CONTEXTUAL,
+    REGEXP,
+    _LAST_ENTRY

[Kasper Lund, 2008/10/24 06:42:50]

I would change _LAST_ENTRY to LAST_ENTRY and let it be equal to REGEXP: enum
Entry { ..., LAST_ENTRY = REGEXP }. The LAST_ENTRY should be the last - not an
additional one. Then you also avoid dealing with it in a switch...

   };
 
   // Finds the script function boilerplate for a source
   // string. Returns an empty handle if the cache doesn't contain a
   // script for the given source string with the right origin.
   static Handle<JSFunction> LookupScript(Handle<String> source,
                                          Handle<Object> name,
                                          int line_offset,
                                          int column_offset);
 
   // Finds the function boilerplate for a source string for
   // eval. Returns an empty handle if the cache doesn't contain a
   // script for the given source string.
   static Handle<JSFunction> LookupEval(Handle<String> source,
                                        Entry entry);
 
+  static Handle<Object> LookupRegExp(Handle<String> source,

[Kasper Lund, 2008/10/24 06:42:50]

Maybe you should explain return value in case of a cache miss?

+                                     int flags);
+
+  static void PutRegExp(Handle<String> source,

[Kasper Lund, 2008/10/24 06:42:50]

Maybe you should rename the Associate method to PutFunction to make it
consistent with PutRegExp? Maybe you should have a comment here that explains
what happens with existing mappings?

+                        int flags,
+                        Handle<FixedArray> data);
+
   // Associate the (source, kind) pair to the boilerplate. This may
   // overwrite an existing mapping.
   static void Associate(Handle<String> source,
                         Entry entry,
                         Handle<JSFunction> boilerplate);
 
   // Clear the cache - also used to initialize the cache at startup.
   static void Clear();
 
   // GC support.
   static void Iterate(ObjectVisitor* v);
 
   // Notify the cache that a mark-sweep garbage collection is about to
   // take place. This is used to retire entries from the cache to
   // avoid keeping them alive too long without using them. For now, we
   // just clear the cache but we should consider are more
   // sophisticated LRU scheme.
   static void MarkCompactPrologue() { Clear(); }
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_COMPILATION_CACHE_H_