Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: Source/core/rendering/svg/RenderSVGShape.h

Issue 810343003: Fix pointer-events:all when stroke="none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove braces from single-line if statement Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/svg/RenderSVGRect.cpp ('k') | Source/core/rendering/svg/RenderSVGShape.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/RenderSVGShape.h
diff --git a/Source/core/rendering/svg/RenderSVGShape.h b/Source/core/rendering/svg/RenderSVGShape.h
index 3fa24bf9487c95bb67f97e13d2f327c2b2e2106e..50fe6e53540f7f5ae46984a6975d589958175e9f 100644
--- a/Source/core/rendering/svg/RenderSVGShape.h
+++ b/Source/core/rendering/svg/RenderSVGShape.h
@@ -84,6 +84,8 @@ protected:
virtual bool shapeDependentStrokeContains(const FloatPoint&);
virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;
+ virtual FloatRect actualStrokeBoundingBox() const { return style()->svgStyle().hasStroke() ? m_strokeBoundingBox : m_fillBoundingBox; }
+
// Give RenderSVGPath a hook for updating markers in updateShapeFromElement.
virtual void processMarkerPositions() { };
@@ -106,7 +108,7 @@ private:
virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint& pointInParent, HitTestAction) override final;
- virtual FloatRect strokeBoundingBox() const override final { return m_strokeBoundingBox; }
+ virtual FloatRect strokeBoundingBox() const override final { return actualStrokeBoundingBox(); }
fs 2015/01/05 10:08:13 This redefines the semantics of this method in thi
FloatRect calculateObjectBoundingBox() const;
FloatRect calculateStrokeBoundingBox() const;
void updatePaintInvalidationBoundingBox();
« no previous file with comments | « Source/core/rendering/svg/RenderSVGRect.cpp ('k') | Source/core/rendering/svg/RenderSVGShape.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698