Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: Source/core/rendering/svg/RenderSVGEllipse.cpp

Issue 810343003: Fix pointer-events:all when stroke="none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove line uniting m_hitTestStrokeBoundingBox with markerRect Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/hittest/rect-hittest-expected.txt ('k') | Source/core/rendering/svg/RenderSVGPath.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/svg/RenderSVGEllipse.cpp
diff --git a/Source/core/rendering/svg/RenderSVGEllipse.cpp b/Source/core/rendering/svg/RenderSVGEllipse.cpp
index 66ac961ce5bc8885d869b849c4e6d79ccfb7e394..3d8f8c0cc1a3d359c2b5d29dfafd7c1d8e1779b1 100644
--- a/Source/core/rendering/svg/RenderSVGEllipse.cpp
+++ b/Source/core/rendering/svg/RenderSVGEllipse.cpp
@@ -49,6 +49,7 @@ void RenderSVGEllipse::updateShapeFromElement()
// to avoid using garbage.
m_fillBoundingBox = FloatRect();
m_strokeBoundingBox = FloatRect();
+ m_hitTestStrokeBoundingBox = FloatRect();
m_center = FloatPoint();
m_radii = FloatSize();
m_usePathFallback = false;
@@ -70,9 +71,9 @@ void RenderSVGEllipse::updateShapeFromElement()
}
m_fillBoundingBox = FloatRect(m_center.x() - m_radii.width(), m_center.y() - m_radii.height(), 2 * m_radii.width(), 2 * m_radii.height());
- m_strokeBoundingBox = m_fillBoundingBox;
- if (style()->svgStyle().hasStroke())
- m_strokeBoundingBox.inflate(strokeWidth() / 2);
+ m_hitTestStrokeBoundingBox = m_fillBoundingBox;
+ m_hitTestStrokeBoundingBox.inflate(strokeWidth() / 2);
+ m_strokeBoundingBox = style()->svgStyle().hasStroke() ? m_hitTestStrokeBoundingBox : m_fillBoundingBox;
}
void RenderSVGEllipse::calculateRadiiAndCenter()
« no previous file with comments | « LayoutTests/svg/hittest/rect-hittest-expected.txt ('k') | Source/core/rendering/svg/RenderSVGPath.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698