Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/svg/hittest/rect-hittest.html

Issue 810343003: Fix pointer-events:all when stroke="none" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove line uniting m_hitTestStrokeBoundingBox with markerRect Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/hittest/pointer-events-all-expected.txt ('k') | LayoutTests/svg/hittest/rect-hittest-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/hittest/rect-hittest.html
diff --git a/LayoutTests/svg/hittest/rect-hittest.html b/LayoutTests/svg/hittest/rect-hittest.html
new file mode 100644
index 0000000000000000000000000000000000000000..5022e1f5675e7fed95ecf2478d03262be6ba5dc3
--- /dev/null
+++ b/LayoutTests/svg/hittest/rect-hittest.html
@@ -0,0 +1,146 @@
+<!DOCTYPE html>
+This tests hit testing on rects with simple strokes, exercising optimized code for hit testing the rects' strokes. If this test passes, you will see "PASS" below.
+<p id="result">Running test...</p>
+<style>
+#rect1:hover,
+#rect2:hover,
+#rect3:hover,
+#rect4:hover,
+#rect5:hover,
+#rect6:hover {
+ stroke: #00f;
+}
+</style>
+<svg id="svg" width="420" height="300" version="1.1">
+ <rect id="border" x="0.5" y="0.5" width="419" height="299" stroke="#000" stroke-width="1" fill="none"/>
+
+ <rect id="rect1" x="70" y="30" width="100" height="80" stroke="#000" stroke-width="20" fill="none"/>
+ <rect id="rect2" x="40" y="150" width="50" height="120" stroke="#000" stroke-width="20" fill="none" transform="rotate(20 65 210)"/>
+ <rect id="rect3" x="140" y="200" width="150" height="70" stroke="#000" stroke-width="20" fill="none"/>
+ <rect id="rect4" x="220" y="50" width="60" height="10" stroke="#000" stroke-width="20" fill="none"/>
+ <rect id="rect5" x="230" y="100" width="10" height="60" stroke="#000" stroke-width="20" fill="none" transform="rotate(-45 235 130)"/>
+ <rect id="rect6" x="310" y="130" width="10" height="10" stroke="#000" stroke-width="20" fill="none"/>
+</svg>
+<script type="text/javascript">
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.waitUntilDone();
+}
+
+var svg = document.getElementById("svg");
+window.onload = function () {
+ var tests = [
+ { x: 30, y: 12, expectedElemId: "svg" },
+ { x: 118, y: 10, expectedElemId: "svg" },
+ { x: 197, y: 12, expectedElemId: "svg" },
+ { x: 201, y: 28, expectedElemId: "svg" },
+ { x: 15, y: 70, expectedElemId: "svg" },
+ { x: 97, y: 52, expectedElemId: "svg" },
+ { x: 149, y: 49, expectedElemId: "svg" },
+ { x: 85, y: 82, expectedElemId: "svg" },
+ { x: 122, y: 98, expectedElemId: "svg" },
+ { x: 154, y: 75, expectedElemId: "svg" },
+ { x: 72, y: 130, expectedElemId: "svg" },
+ { x: 48, y: 145, expectedElemId: "svg" },
+ { x: 31, y: 279, expectedElemId: "svg" },
+ { x: 28, y: 201, expectedElemId: "svg" },
+ { x: 71, y: 179, expectedElemId: "svg" },
+ { x: 43, y: 244, expectedElemId: "svg" },
+ { x: 74, y: 219, expectedElemId: "svg" },
+ { x: 94, y: 261, expectedElemId: "svg" },
+ { x: 126, y: 231, expectedElemId: "svg" },
+ { x: 146, y: 185, expectedElemId: "svg" },
+ { x: 173, y: 216, expectedElemId: "svg" },
+ { x: 225, y: 258, expectedElemId: "svg" },
+ { x: 247, y: 284, expectedElemId: "svg" },
+ { x: 286, y: 174, expectedElemId: "svg" },
+ { x: 254, y: 120, expectedElemId: "svg" },
+ { x: 203, y: 96, expectedElemId: "svg" },
+ { x: 244, y: 163, expectedElemId: "svg" },
+ { x: 300, y: 37, expectedElemId: "svg" },
+ { x: 335, y: 136, expectedElemId: "svg" },
+
+ // Test all four outer corner points of #rect1
+ { x: 60, y: 20, expectedElemId: "rect1" },
+ { x: 180, y: 20, expectedElemId: "rect1" },
+ { x: 180, y: 120, expectedElemId: "rect1" },
+ { x: 60, y: 120, expectedElemId: "rect1" },
+ // Test all four interior corner points of #rect1
+ { x: 80, y: 40, expectedElemId: "rect1" },
+ { x: 160, y: 40, expectedElemId: "rect1" },
+ { x: 160, y: 100, expectedElemId: "rect1" },
+ { x: 80, y: 100, expectedElemId: "rect1" },
+
+ { x: 67, y: 56, expectedElemId: "rect1" },
+ { x: 146, y: 27, expectedElemId: "rect1" },
+ { x: 173, y: 111, expectedElemId: "rect1" },
+
+ { x: 28, y: 242, expectedElemId: "rect2" },
+ { x: 51, y: 182, expectedElemId: "rect2" },
+ { x: 89, y: 155, expectedElemId: "rect2" },
+
+ { x: 136, y: 198, expectedElemId: "rect3" },
+ { x: 177, y: 270, expectedElemId: "rect3" },
+ { x: 275, y: 197, expectedElemId: "rect3" },
+ { x: 297, y: 233, expectedElemId: "rect3" },
+
+ { x: 235, y: 47, expectedElemId: "rect4" },
+ { x: 272, y: 61, expectedElemId: "rect4" },
+ { x: 290, y: 70, expectedElemId: "rect4" },
+
+ { x: 233, y: 140, expectedElemId: "rect5" },
+
+ { x: 312, y: 128, expectedElemId: "rect6" },
+ { x: 330, y: 150, expectedElemId: "rect6" }
+ ];
+
+ var bcr = svg.getBoundingClientRect(),
+ x0 = bcr.left << 0,
+ y0 = bcr.top << 0;
+
+ for (var i = 0; i < tests.length; ++i) {
+ var test = tests[i],
+ elem = document.elementFromPoint(x0 + test.x, y0 + test.y),
+ expectedElem = document.getElementById(test.expectedElemId),
+ success;
+ if (elem !== expectedElem) {
+ success = false;
+ result.textContent = "FAIL - unexpected element at (" + test.x + ", " + test.y + ")";
+ } else {
+ success = true;
+ }
+
+ // Draw a dot and a label at the test point (helps with identification).
+ markPoint(test.x, test.y, success);
+ }
+
+ if (result.textContent == "Running test...")
+ result.textContent = "PASS";
+
+ if (window.testRunner)
+ testRunner.notifyDone();
+};
+
+function markPoint(testX, testY, success) {
+ var dot = document.createElementNS("http://www.w3.org/2000/svg", "circle");
+ dot.setAttribute("pointer-events", "none");
+ dot.setAttribute("cx", testX);
+ dot.setAttribute("cy", testY);
+ dot.setAttribute("r", "2");
+ if (success)
+ dot.setAttribute("fill", "#0c0");
+ else
+ dot.setAttribute("fill", "red");
+ svg.appendChild(dot);
+ var label = document.createElementNS("http://www.w3.org/2000/svg", "text");
+ label.setAttribute("pointer-events", "none");
+ label.setAttribute("x", testX + 4);
+ label.setAttribute("y", testY);
+ label.textContent = "(" + testX + ", " + testY + ")";
+ if (success)
+ label.setAttribute("fill", "#0c0");
+ else
+ label.setAttribute("fill", "red");
+ svg.appendChild(label);
+}
+</script>
« no previous file with comments | « LayoutTests/svg/hittest/pointer-events-all-expected.txt ('k') | LayoutTests/svg/hittest/rect-hittest-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698