Fix pointer-events:all when stroke="none"

Source/core/rendering/svg/RenderSVGPath.cpp

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2005, 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
  * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
  * Copyright (C) 2011 University of Szeged
@@ skipping 31 matching lines @@
 {
 }
 
 RenderSVGPath::~RenderSVGPath()
 {
 }
 
 void RenderSVGPath::updateShapeFromElement()
 {
     RenderSVGShape::updateShapeFromElement();
+
+    FloatRect markerRect;
+    if (m_markerPositions.isEmpty()) {

[fs, 2015/01/22 12:15:58]

The if-branch is a no-op, so suggest reversing this condition (and dropping the
if-branch).

+        markerRect = FloatRect();
+    } else {
+        markerRect = this->markerRect(strokeWidth());
+        m_hitTestStrokeBoundingBox.unite(markerRect);

[fs, 2015/01/22 12:15:58]

IIRC markers are not included in the hit test, so maybe this should be moved
down after the if at the end instead.

+    }
+
     updateZeroLengthSubpaths();
-
-    m_strokeBoundingBox = calculateUpdatedStrokeBoundingBox();
+    m_hitTestStrokeBoundingBox = calculateUpdatedHitTestStrokeBoundingBox();
+    if (style()->svgStyle().hasStroke()) {
+        m_strokeBoundingBox = m_hitTestStrokeBoundingBox;
+    } else {
+        m_strokeBoundingBox = m_fillBoundingBox;
+        m_strokeBoundingBox.unite(markerRect);
+    }
 }
 
-FloatRect RenderSVGPath::calculateUpdatedStrokeBoundingBox() const
+FloatRect RenderSVGPath::calculateUpdatedHitTestStrokeBoundingBox() const
 {
-    FloatRect strokeBoundingBox = m_strokeBoundingBox;
+    FloatRect strokeBoundingBox = m_hitTestStrokeBoundingBox;
 
-    if (!m_markerPositions.isEmpty())
-        strokeBoundingBox.unite(markerRect(strokeWidth()));
-
-    if (style()->svgStyle().hasStroke()) {
-        // FIXME: zero-length subpaths do not respect vector-effect = non-scaling-stroke.
-        float strokeWidth = this->strokeWidth();
-        for (size_t i = 0; i < m_zeroLengthLinecapLocations.size(); ++i)
-            strokeBoundingBox.unite(zeroLengthSubpathRect(m_zeroLengthLinecapLocations[i], strokeWidth));
-    }
+    // FIXME: zero-length subpaths do not respect vector-effect = non-scaling-stroke.
+    const float strokeWidth = this->strokeWidth();
+    for (size_t i = 0; i < m_zeroLengthLinecapLocations.size(); ++i)
+        strokeBoundingBox.unite(zeroLengthSubpathRect(m_zeroLengthLinecapLocations[i], strokeWidth));
 
     return strokeBoundingBox;
 }
 
 bool RenderSVGPath::shapeDependentStrokeContains(const FloatPoint& point)
 {
     if (RenderSVGShape::shapeDependentStrokeContains(point))
         return true;
 
     const SVGRenderStyle& svgStyle = style()->svgStyle();
+    const float strokeWidth = this->strokeWidth();
     for (size_t i = 0; i < m_zeroLengthLinecapLocations.size(); ++i) {
         ASSERT(svgStyle.hasStroke());
-        float strokeWidth = this->strokeWidth();
         if (svgStyle.capStyle() == SquareCap) {
             if (zeroLengthSubpathRect(m_zeroLengthLinecapLocations[i], strokeWidth).contains(point))
                 return true;
         } else {
             ASSERT(svgStyle.capStyle() == RoundCap);
             FloatPoint radiusVector(point.x() - m_zeroLengthLinecapLocations[i].x(), point.y() -  m_zeroLengthLinecapLocations[i].y());
             if (radiusVector.lengthSquared() < strokeWidth * strokeWidth * .25f)
                 return true;
         }
     }
@@ skipping 71 matching lines @@
     ASSERT(resources);
 
     RenderSVGResourceMarker* markerStart = resources->markerStart();
 
     SVGMarkerData markerData(m_markerPositions, markerStart ? markerStart->orientType() == SVGMarkerOrientAutoStartReverse : false);
     path().apply(&markerData, SVGMarkerData::updateFromPathElement);
     markerData.pathIsDone();
 }
 
 }