Fix pointer-events:all when stroke="none"

Source/core/rendering/svg/RenderSVGShape.cpp

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2005, 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
  * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
  * Copyright (C) 2011 University of Szeged
@@ skipping 46 matching lines @@
 void RenderSVGShape::updateShapeFromElement()
 {
     m_path.clear();
     m_path = adoptPtr(new Path);
     ASSERT(RenderSVGShape::isShapeEmpty());
 
     updatePathFromGraphicsElement(toSVGGraphicsElement(element()), path());
     processMarkerPositions();
 
     m_fillBoundingBox = calculateObjectBoundingBox();
-    m_strokeBoundingBox = calculateStrokeBoundingBox();
+    m_hitTestStrokeBoundingBox = calculateHitTestStrokeBoundingBox();
 }
 
 bool RenderSVGShape::shapeDependentStrokeContains(const FloatPoint& point)
 {
     ASSERT(m_path);
     StrokeData strokeData;
     SVGRenderSupport::applyStrokeStyleToStrokeData(&strokeData, style(), this);
 
     if (hasNonScalingStroke()) {
         AffineTransform nonScalingTransform = nonScalingStrokeTransform();
@@ skipping 16 matching lines @@
         return false;
 
     if (requiresFill && !SVGPaintServer::existsForRenderer(*this, style(), ApplyToFillMode))
         return false;
 
     return shapeDependentFillContains(point, fillRule);
 }
 
 bool RenderSVGShape::strokeContains(const FloatPoint& point, bool requiresStroke)
 {
-    if (!strokeBoundingBox().contains(point))
+    if (!(requiresStroke ? strokeBoundingBox() : m_hitTestStrokeBoundingBox).contains(point))

[fs, 2015/01/12 13:00:04]

Not particularly fond of this construct... Feels like plain nested ifs would be
a better choice.

         return false;
 
     if (requiresStroke && !SVGPaintServer::existsForRenderer(*this, style(), ApplyToStrokeMode))
         return false;
 
     return shapeDependentStrokeContains(point);
 }
 
 void RenderSVGShape::updateLocalTransform()
 {
@@ skipping 99 matching lines @@
             return true;
     }
     return false;
 }
 
 FloatRect RenderSVGShape::calculateObjectBoundingBox() const
 {
     return path().boundingRect();
 }
 
-FloatRect RenderSVGShape::calculateStrokeBoundingBox() const
+FloatRect RenderSVGShape::calculateHitTestStrokeBoundingBox() const
 {
     ASSERT(m_path);
     FloatRect strokeBoundingBox = m_fillBoundingBox;
 
-    if (style()->svgStyle().hasStroke()) {
-        StrokeData strokeData;
-        SVGRenderSupport::applyStrokeStyleToStrokeData(&strokeData, style(), this);
-        if (hasNonScalingStroke()) {
-            AffineTransform nonScalingTransform = nonScalingStrokeTransform();
-            if (nonScalingTransform.isInvertible()) {
-                Path* usePath = nonScalingStrokePath(m_path.get(), nonScalingTransform);
-                FloatRect strokeBoundingRect = usePath->strokeBoundingRect(strokeData);
-                strokeBoundingRect = nonScalingTransform.inverse().mapRect(strokeBoundingRect);
-                strokeBoundingBox.unite(strokeBoundingRect);
-            }
-        } else {
-            strokeBoundingBox.unite(path().strokeBoundingRect(strokeData));
+    StrokeData strokeData;
+    SVGRenderSupport::applyStrokeStyleToStrokeData(&strokeData, style(), this);
+    if (hasNonScalingStroke()) {
+        AffineTransform nonScalingTransform = nonScalingStrokeTransform();
+        if (nonScalingTransform.isInvertible()) {
+            Path* usePath = nonScalingStrokePath(m_path.get(), nonScalingTransform);
+            FloatRect strokeBoundingRect = usePath->strokeBoundingRect(strokeData);
+            strokeBoundingRect = nonScalingTransform.inverse().mapRect(strokeBoundingRect);
+            strokeBoundingBox.unite(strokeBoundingRect);
         }
+    } else {
+        strokeBoundingBox.unite(path().strokeBoundingRect(strokeData));
     }
 
     return strokeBoundingBox;
 }
 
 void RenderSVGShape::updatePaintInvalidationBoundingBox()
 {
     m_paintInvalidationBoundingBox = strokeBoundingBox();
     if (strokeWidth() < 1.0f && !m_paintInvalidationBoundingBox.isEmpty())
         m_paintInvalidationBoundingBox.inflate(1);
     SVGRenderSupport::intersectPaintInvalidationRectWithResources(this, m_paintInvalidationBoundingBox);
 }
 
 float RenderSVGShape::strokeWidth() const
 {
     SVGLengthContext lengthContext(element());
     return style()->svgStyle().strokeWidth()->value(lengthContext);
 }
 
 }