Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 810283003: replace COMPILE_ASSERT with static_assert in chrome/[r-z]*/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spellwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in chrome/[r-z]*/ BUG=442514 Committed: https://crrev.com/ee997022ea745adec4b4e1d90ccb9457cd2d81ed Cr-Commit-Position: refs/heads/master@{#309968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M chrome/renderer/spellchecker/hunspell_engine.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/test/logging/win/file_logger.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/tools/profile_reset/jtl_parser_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/media_galleries/pmp_column_reader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@James: PTAL
6 years ago (2014-12-23 01:04:51 UTC) #2
James Hawkins
lgtm
5 years, 11 months ago (2015-01-05 21:08:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810283003/1
5 years, 11 months ago (2015-01-05 21:25:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-05 22:19:02 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 22:21:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee997022ea745adec4b4e1d90ccb9457cd2d81ed
Cr-Commit-Position: refs/heads/master@{#309968}

Powered by Google App Engine
This is Rietveld 408576698