Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 810283002: Expose the HTMLDetailsElement and RadioNodeList interfaces (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose the HTMLDetailsElement and RadioNodeList interfaces Firefox Nightly already exposes the RadioNodeList interface, but not HTMLDetailsElement as it doesn't support <details>: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details IE11 exposes neither of these interfaces. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187537

Patch Set 1 #

Patch Set 2 : revert oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/html/RadioNodeList.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
PTAL
6 years ago (2014-12-18 15:59:55 UTC) #2
philipj_slow
revert oops
6 years ago (2014-12-18 23:43:00 UTC) #3
mlamouri (slow - plz ping)
drive-by lgtm. I don't think it's dangerous to expose HTML{Foo}Element interfaces and RadioNodeList being also ...
6 years ago (2014-12-19 10:47:57 UTC) #5
philipj_slow
Right, and not exposing HTMLDetailsElement when we in fact support <details> could mess with feature ...
6 years ago (2014-12-19 12:00:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810283002/20001
6 years ago (2014-12-19 12:01:15 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-19 14:40:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187537

Powered by Google App Engine
This is Rietveld 408576698