Issue 81023002: Remove dead code unnecessarily added by r231563 and 236449

Issue 81023002: Remove dead code unnecessarily added by r231563 and 236449 (Closed)

Created:
7 years, 1 month ago by yukawa

Modified:
7 years ago

Reviewers:
Hiro Komatsu, kochi, Yuki

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove dead code unnecessarily added by r231563 and 236449 We don't need to support following event callbacks in production. - InputMethodObserver::OnCaretBoundsChanged - InputMethodObserver::OnInputLocaleChanged - InputMethodObserver::OnFocus - InputMethodObserver::OnBlur - InputMethodObserver::OnTextInputTypeChanged This CL get rid of them from ui::InputMethodBase and its subclassed and ui::RemoteInputMethodWin. These code were unnecessarily added by r231563 and 236449. BUG=322038 TEST=covered by unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237063

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Add missing '!'s to address Yuki's comment #

Patch Set 3 : rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -299 lines)			Patch
M	ui/base/ime/input_method_base.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/ime/input_method_base.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	ui/base/ime/input_method_base_unittest.cc	View		6 chunks	+19 lines, -104 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.cc	View		2 chunks	+52 lines, -59 lines	0 comments	Download
M	ui/base/ime/input_method_imm32.cc	View		1 chunk	+17 lines, -16 lines	0 comments	Download
M	ui/base/ime/input_method_linux_x11.cc	View	1	1 chunk	+9 lines, -12 lines	0 comments	Download
M	ui/base/ime/input_method_tsf.cc	View		1 chunk	+7 lines, -8 lines	0 comments	Download
M	ui/base/ime/remote_input_method_win.cc	View	1 2	7 chunks	+0 lines, -27 lines	0 comments	Download
M	ui/base/ime/remote_input_method_win_unittest.cc	View	1 2	4 chunks	+1 line, -61 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

yukawa

Hi, this is another cleanups of ui::InputMethodObserver. Could you take a look?

7 years ago (2013-11-25 08:43:59 UTC) #1

Yuki

Please address my comments below, then LGTM. https://codereview.chromium.org/81023002/diff/210002/ui/base/ime/input_method_linux_x11.cc File ui/base/ime/input_method_linux_x11.cc (right): https://codereview.chromium.org/81023002/diff/210002/ui/base/ime/input_method_linux_x11.cc#newcode111 ui/base/ime/input_method_linux_x11.cc:111: if (IsTextInputClientFocused(client)) ...

7 years ago (2013-11-25 08:58:49 UTC) #3

yukawa

https://codereview.chromium.org/81023002/diff/210002/ui/base/ime/input_method_linux_x11.cc File ui/base/ime/input_method_linux_x11.cc (right): https://codereview.chromium.org/81023002/diff/210002/ui/base/ime/input_method_linux_x11.cc#newcode111 ui/base/ime/input_method_linux_x11.cc:111: if (IsTextInputClientFocused(client)) On 2013/11/25 08:58:49, Yuki wrote: > You ...

7 years ago (2013-11-25 09:03:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/81023002/480001

7 years ago (2013-11-25 10:23:40 UTC) #7

Message was sent while issue was closed.

Change committed as 237063

Expand Messages | Collapse Messages