Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5268)

Unified Diff: chrome/browser/profiles/off_the_record_profile_impl.cc

Issue 8102019: redesign and reimplement proxy config service and tracker, revise proxy ui on cros (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/off_the_record_profile_impl.cc
===================================================================
--- chrome/browser/profiles/off_the_record_profile_impl.cc (revision 107101)
+++ chrome/browser/profiles/off_the_record_profile_impl.cc (working copy)
@@ -25,7 +25,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_special_storage_policy.h"
#include "chrome/browser/extensions/extension_webrequest_api.h"
-#include "chrome/browser/net/pref_proxy_config_service.h"
+#include "chrome/browser/net/proxy_service_factory.h"
#include "chrome/browser/plugin_prefs.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/prefs/pref_service.h"
@@ -60,6 +60,7 @@
#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/preferences.h"
+#include "chrome/browser/chromeos/proxy_config_service_impl.h"
#endif
namespace {
@@ -144,7 +145,7 @@
if (host_content_settings_map_)
host_content_settings_map_->ShutdownOnUIThread();
- if (pref_proxy_config_tracker_)
+ if (pref_proxy_config_tracker_.get())
pref_proxy_config_tracker_->DetachFromPrefService();
ExtensionService* extension_service = GetExtensionService();
@@ -548,10 +549,12 @@
}
#endif // defined(OS_CHROMEOS)
-PrefProxyConfigTracker* OffTheRecordProfileImpl::GetProxyConfigTracker() {
- if (!pref_proxy_config_tracker_)
- pref_proxy_config_tracker_ = new PrefProxyConfigTracker(GetPrefs());
- return pref_proxy_config_tracker_;
+PrefProxyConfigTrackerType* OffTheRecordProfileImpl::GetProxyConfigTracker() {
+ if (!pref_proxy_config_tracker_.get()) {
+ pref_proxy_config_tracker_.reset(
+ ProxyServiceFactory::CreatePrefProxyConfigTracker(GetPrefs()));
+ }
+ return pref_proxy_config_tracker_.get();
}
chrome_browser_net::Predictor* OffTheRecordProfileImpl::GetNetworkPredictor() {

Powered by Google App Engine
This is Rietveld 408576698