Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: chrome/browser/chromeos/proxy_cros_settings_provider.h

Issue 8102019: redesign and reimplement proxy config service and tracker, revise proxy ui on cros (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_cros_settings_provider.h
===================================================================
--- chrome/browser/chromeos/proxy_cros_settings_provider.h (revision 107101)
+++ chrome/browser/chromeos/proxy_cros_settings_provider.h (working copy)
@@ -11,11 +11,13 @@
#include "chrome/browser/chromeos/cros_settings_provider.h"
#include "chrome/browser/chromeos/proxy_config_service_impl.h"
+class Profile;
+
namespace chromeos {
class ProxyCrosSettingsProvider : public CrosSettingsProvider {
public:
- ProxyCrosSettingsProvider();
+ explicit ProxyCrosSettingsProvider(Profile* profile);
// CrosSettingsProvider implementation.
virtual bool Get(const std::string& path, Value** out_value) const OVERRIDE;
virtual bool HandlesSetting(const std::string& path) const OVERRIDE;
@@ -28,13 +30,6 @@
// displayed and possibly edited on.
void MakeActiveNetworkCurrent();
- // Returns name of current network that has been set via SetCurrentNetwork or
- // MakeActiveNetworkCurrent.
- const std::string& GetCurrentNetworkName() const;
-
- // Returns true if user has selected to use shared proxies.
- bool IsUsingSharedProxies() const;
-
private:
// CrosSettingsProvider implementation.
virtual void DoSet(const std::string& path, Value* value) OVERRIDE;
@@ -57,6 +52,8 @@
Value* CreateServerPortValue(
const ProxyConfigServiceImpl::ProxyConfig::ManualProxy& proxy) const;
+ Profile* profile_; // Weak ptr.
+
DISALLOW_COPY_AND_ASSIGN(ProxyCrosSettingsProvider);
};

Powered by Google App Engine
This is Rietveld 408576698