Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/ui/webui/options/advanced_options_handler.cc

Issue 8102019: redesign and reimplement proxy config service and tracker, revise proxy ui on cros (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/advanced_options_handler.cc
===================================================================
--- chrome/browser/ui/webui/options/advanced_options_handler.cc (revision 108608)
+++ chrome/browser/ui/webui/options/advanced_options_handler.cc (working copy)
@@ -245,8 +245,10 @@
auto_open_files_.Init(prefs::kDownloadExtensionsToOpen, prefs, this);
default_font_size_.Init(prefs::kWebKitDefaultFontSize, prefs, this);
+#if !defined(OS_CHROMEOS)
proxy_prefs_.reset(
PrefSetObserver::CreateProxyPrefSetObserver(prefs, this));
+#endif // !defined(OS_CHROMEOS)
// Return result from the superclass.
return handler;
@@ -308,8 +310,10 @@
std::string* pref_name = content::Details<std::string>(details).ptr();
if (*pref_name == prefs::kDownloadExtensionsToOpen) {
SetupAutoOpenFileTypesDisabledAttribute();
+#if !defined(OS_CHROMEOS)
} else if (proxy_prefs_->IsObserved(*pref_name)) {
SetupProxySettingsSection();
+#endif // !defined(OS_CHROMEOS)
} else if ((*pref_name == prefs::kCloudPrintEmail) ||
(*pref_name == prefs::kCloudPrintProxyEnabled)) {
#if !defined(OS_CHROMEOS)
@@ -547,6 +551,7 @@
}
void AdvancedOptionsHandler::SetupProxySettingsSection() {
+#if !defined(OS_CHROMEOS)
// Disable the button if proxy settings are managed by a sysadmin or
// overridden by an extension.
PrefService* pref_service = Profile::FromWebUI(web_ui_)->GetPrefs();
@@ -570,6 +575,7 @@
web_ui_->CallJavascriptFunction(
"options.AdvancedOptions.SetupProxySettingsSection", disabled, label);
+#endif // !defined(OS_CHROMEOS)
}
void AdvancedOptionsHandler::SetupSSLConfigSettings() {

Powered by Google App Engine
This is Rietveld 408576698