Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3930)

Unified Diff: chrome/browser/profiles/profile_impl.cc

Issue 8102019: redesign and reimplement proxy config service and tracker, revise proxy ui on cros (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_impl.cc
===================================================================
--- chrome/browser/profiles/profile_impl.cc (revision 108608)
+++ chrome/browser/profiles/profile_impl.cc (working copy)
@@ -54,7 +54,7 @@
#include "chrome/browser/net/gaia/token_service.h"
#include "chrome/browser/net/net_pref_observer.h"
#include "chrome/browser/net/predictor.h"
-#include "chrome/browser/net/pref_proxy_config_service.h"
+#include "chrome/browser/net/proxy_service_factory.h"
#include "chrome/browser/net/ssl_config_service_manager.h"
#include "chrome/browser/net/url_fixer_upper.h"
#include "chrome/browser/password_manager/password_store_default.h"
@@ -136,6 +136,7 @@
#include "chrome/browser/chromeos/locale_change_guard.h"
#include "chrome/browser/chromeos/login/user_manager.h"
#include "chrome/browser/chromeos/preferences.h"
+#include "chrome/browser/chromeos/proxy_config_service_impl.h"
#endif
using base::Time;
@@ -608,7 +609,7 @@
if (extension_message_service_)
extension_message_service_->DestroyingProfile();
- if (pref_proxy_config_tracker_)
+ if (pref_proxy_config_tracker_.get())
pref_proxy_config_tracker_->DetachFromPrefService();
if (protocol_handler_registry_)
@@ -1547,10 +1548,11 @@
#endif // defined(OS_CHROMEOS)
PrefProxyConfigTracker* ProfileImpl::GetProxyConfigTracker() {
- if (!pref_proxy_config_tracker_)
- pref_proxy_config_tracker_ = new PrefProxyConfigTracker(GetPrefs());
-
- return pref_proxy_config_tracker_;
+ if (!pref_proxy_config_tracker_.get()) {
+ pref_proxy_config_tracker_.reset(
+ ProxyServiceFactory::CreatePrefProxyConfigTracker(GetPrefs()));
+ }
+ return pref_proxy_config_tracker_.get();
}
chrome_browser_net::Predictor* ProfileImpl::GetNetworkPredictor() {

Powered by Google App Engine
This is Rietveld 408576698