[Android] Add file-based gtest filtering for gtests on AMP.

[Android] Add file-based gtest filtering for gtests on AMP.

BUG=428729
Committed: https://crrev.com/e6c56015219f5824bf0cad7f69d888f14e693e3e
Cr-Commit-Position: refs/heads/master@{#311363}

[jbudorick, 2015-01-13 19:17:55]

jbudorick@chromium.org changed reviewers:
+ klundberg@chromium.org, rnephew@chromium.org

[jbudorick, 2015-01-13 19:17:56]

https://codereview.chromium.org/810193007/diff/1/build/android/pylib/remote/d...
File build/android/pylib/remote/device/remote_device_test_run.py (right):

https://codereview.chromium.org/810193007/diff/1/build/android/pylib/remote/d...
build/android/pylib/remote/device/remote_device_test_run.py:244:
'videocapture=0',
We can revisit this when we support instrumentation tests, but for now, I'm
disabling video capture.

[jbudorick, 2015-01-13 19:26:28]

https://codereview.chromium.org/810193007/diff/1/build/android/pylib/remote/d...
File build/android/pylib/remote/device/remote_device_gtest_run.py (right):

https://codereview.chromium.org/810193007/diff/1/build/android/pylib/remote/d...
build/android/pylib/remote/device/remote_device_gtest_run.py:20:
'org.chromium.native_test.ChromeNativeTestActivity.CommandLineFile')
oh, the other note: we have to do this via CommandLineFile (vs passing the flags
directly in the intent via CommandLineFlags) because of b/18952272

[klundberg, 2015-01-13 19:33:15]

Only minor things so giving LGTM

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
File
testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java
(right):

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java:86:
commandLineFilePath = Environment.getExternalStorageDirectory() + "/"
This line seems longer than 80 characters?

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
File
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java:187:
Log.e(TAG, "FAILED: " + entry.getKey());
Leftover from debugging?

[jbudorick, 2015-01-13 19:38:42]

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
File
testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java
(right):

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java:86:
commandLineFilePath = Environment.getExternalStorageDirectory() + "/"
On 2015/01/13 19:33:15, klundberg wrote:
> This line seems longer than 80 characters?

It is, but the java line limit is 100 characters.

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
File
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java:187:
Log.e(TAG, "FAILED: " + entry.getKey());
On 2015/01/13 19:33:15, klundberg wrote:
> Leftover from debugging?

No, this is intentional. I've seen a few weird flakes both locally and on the
bot that I think this could help diagnose.

[jbudorick, 2015-01-13 19:39:24]

jbudorick@chromium.org changed reviewers:
+ tedchoc@chromium.org

[jbudorick, 2015-01-13 19:39:24]

+Ted for testing/android/*

[klundberg, 2015-01-13 19:41:16]

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
File
testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java
(right):

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java:86:
commandLineFilePath = Environment.getExternalStorageDirectory() + "/"
On 2015/01/13 19:38:41, jbudorick wrote:
> On 2015/01/13 19:33:15, klundberg wrote:
> > This line seems longer than 80 characters?
> 
> It is, but the java line limit is 100 characters.

Sorry, I don't know what I was thinking as I reviewed the other Java file using
100 characters...long day already:-)

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
File
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java:187:
Log.e(TAG, "FAILED: " + entry.getKey());
On 2015/01/13 19:38:42, jbudorick wrote:
> On 2015/01/13 19:33:15, klundberg wrote:
> > Leftover from debugging?
> 
> No, this is intentional. I've seen a few weird flakes both locally and on the
> bot that I think this could help diagnose.

ok, I was just confused about Log.e. If this is something for debugging, it
seems like logging it as an error isn't the right thing to do. 

Could you at least add a TODO to remove it after debugging failures?

[jbudorick, 2015-01-13 19:47:01]

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
File
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/810193007/diff/1/testing/android/java/src/org...
testing/android/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java:187:
Log.e(TAG, "FAILED: " + entry.getKey());
On 2015/01/13 19:41:16, klundberg wrote:
> On 2015/01/13 19:38:42, jbudorick wrote:
> > On 2015/01/13 19:33:15, klundberg wrote:
> > > Leftover from debugging?
> > 
> > No, this is intentional. I've seen a few weird flakes both locally and on
the
> > bot that I think this could help diagnose.
> 
> ok, I was just confused about Log.e. If this is something for debugging, it
> seems like logging it as an error isn't the right thing to do. 
> 
> Could you at least add a TODO to remove it after debugging failures?

Switched to Log.d and added a TODO.

[Ted C, 2015-01-13 21:28:52]

lgtm

[jbudorick, 2015-01-13 21:30:49]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-01-13 21:32:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/810193007/20001

[commit-bot: I haz the power, 2015-01-13 23:50:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-13 23:50:49]

Patchset 2 (id:??) landed as
https://crrev.com/e6c56015219f5824bf0cad7f69d888f14e693e3e
Cr-Commit-Position: refs/heads/master@{#311363}