Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 810193006: Remove redundant OS checks in chrome_shell.gypi (Closed)

Created:
5 years, 11 months ago by mstrum
Modified:
5 years, 11 months ago
Reviewers:
*newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant OS checks in chrome_shell.gypi chrome_shell.gypi is only included if OS=="android" so there is no reason to test it again. BUG=none Committed: https://crrev.com/8c70705f1cb3d9726c3ba8f782209173193f8d3e Cr-Commit-Position: refs/heads/master@{#311517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_shell.gypi View 2 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstrum
Hi newt, PTAL, I noticed these so I thought I'd clean it up a little~ ...
5 years, 11 months ago (2015-01-13 16:50:00 UTC) #3
newt (away)
lgtm
5 years, 11 months ago (2015-01-14 16:40:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810193006/1
5 years, 11 months ago (2015-01-14 16:47:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 18:24:42 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:25:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c70705f1cb3d9726c3ba8f782209173193f8d3e
Cr-Commit-Position: refs/heads/master@{#311517}

Powered by Google App Engine
This is Rietveld 408576698