runtime/vm/regexp.cc - Issue 810193005: Create a symbol before setting the irregexp function name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp.cc

Issue 810193005: Create a symbol before setting the irregexp function name. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/regexp.cc

diff --git a/runtime/vm/regexp.cc b/runtime/vm/regexp.cc

index a5d4fece801efed3927f35a1ae7e785686a6e889..5d31fbf41616e448d836ec2d208133bbc673883c 100644

--- a/runtime/vm/regexp.cc

+++ b/runtime/vm/regexp.cc

@@ -5103,11 +5103,12 @@ static void CreateSpecializedFunction(Isolate* isolate,

Function& fn = Function::Handle(isolate, Function::New(

// Append the regexp pattern to the function name.

- String::Handle(isolate, String::Concat(

+ String::Handle(isolate, Symbols::New(

String::Handle(isolate, String::Concat(

- Symbols::Irregexp(),

- Symbols::ColonSpace(), Heap::kOld)),

- String::Handle(regexp.pattern()), Heap::kOld)),

+ String::Handle(isolate, String::Concat(

+ Symbols::Irregexp(),

+ Symbols::ColonSpace(), Heap::kOld)),

+ String::Handle(regexp.pattern()), Heap::kOld)))),

RawFunction::kIrregexpFunction,

true, // Static.

false, // Not const.

« no previous file with comments | « no previous file | no next file » | no next file with comments »