Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 810153004: Update harfbuzz to 0.9.37 (Closed)

Created:
6 years ago by jungshik at Google
Modified:
5 years, 11 months ago
Reviewers:
behdad_google, behdad, bashi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update harfbuzz to 0.9.37 We were at 0.9.35 with a few cherry-picks from the upstream. It's time to catch up with the upstream. BUG=445658 TEST=blink layout tests Committed: https://crrev.com/5a1c8035967936fe590391a5068f9c91bc2a7fc8 Cr-Commit-Position: refs/heads/master@{#310115}

Patch Set 1 #

Patch Set 2 : delete a patch not necessary any more #

Patch Set 3 : add back missing files #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1752 lines, -2704 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 1 2 2 chunks +5 lines, -10 lines 0 comments Download
D third_party/harfbuzz-ng/gsubgpos.patch View 1 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-buffer-deserialize-json.hh View 1 2 14 chunks +31 lines, -31 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-buffer-deserialize-text.hh View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-file-private.hh View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 9 chunks +83 lines, -36 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 7 chunks +132 lines, -76 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-hhea-table.hh View 2 chunks +35 lines, -30 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-hmtx-table.hh View 3 chunks +24 lines, -13 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh View 13 chunks +20 lines, -20 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 16 chunks +55 lines, -36 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-win1256.hh View 1 chunk +3 lines, -0 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.hh View 1 2 12 chunks +1325 lines, -1295 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-machine.hh View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-shape-complex-sea-machine.hh View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 5 chunks +8 lines, -47 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-uniscribe.h View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-uniscribe.cc View 1 2 1 chunk +0 lines, -1015 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-version.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
jungshik at Google
This will be landed after a cherry-pick is baked in the trunk/canary/dev for a while.
6 years ago (2014-12-18 19:28:21 UTC) #2
behdad_google
This can't possibly be correct. Why are you deleting all the autogenerated headers?
6 years ago (2014-12-18 23:16:38 UTC) #4
behdad_google
On 2014/12/18 23:16:38, behdad_google wrote: > This can't possibly be correct. Why are you deleting ...
6 years ago (2014-12-18 23:17:21 UTC) #5
jungshik at Google
On 2014/12/18 23:17:21, behdad_google wrote: > On 2014/12/18 23:16:38, behdad_google wrote: > > This can't ...
6 years ago (2014-12-19 11:08:18 UTC) #6
jungshik at Google
On 2014/12/19 11:08:18, Jungshik Shin wrote: > On 2014/12/18 23:17:21, behdad_google wrote: > > On ...
6 years ago (2014-12-19 17:46:18 UTC) #7
jungshik at Google
On 2014/12/19 17:46:18, Jungshik Shin wrote: > On 2014/12/19 11:08:18, Jungshik Shin wrote: > > ...
6 years ago (2014-12-19 17:50:26 UTC) #8
behdad_google
On 2014/12/19 17:50:26, Jungshik Shin wrote: > On 2014/12/19 17:46:18, Jungshik Shin wrote: > > ...
6 years ago (2014-12-19 18:46:25 UTC) #9
jungshik at Google
Behdad, do you see any problem with the latest patch set?
5 years, 11 months ago (2014-12-31 01:01:59 UTC) #10
behdad_google
On 2014/12/31 01:01:59, jshin(ooo till jan 4) wrote: > Behdad, do you see any problem ...
5 years, 11 months ago (2014-12-31 01:03:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810153004/60001
5 years, 11 months ago (2015-01-06 01:13:15 UTC) #14
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-06 01:13:18 UTC) #16
bashi
On 2015/01/06 01:13:18, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 11 months ago (2015-01-06 01:15:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810153004/60001
5 years, 11 months ago (2015-01-06 17:57:12 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-06 19:16:38 UTC) #20
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 19:17:27 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5a1c8035967936fe590391a5068f9c91bc2a7fc8
Cr-Commit-Position: refs/heads/master@{#310115}

Powered by Google App Engine
This is Rietveld 408576698