Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: remoting/host/ipc_util_win.cc

Issue 810133003: replace NULL->nullptr in src/remoting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/host/ipc_mouse_cursor_monitor.cc ('k') | remoting/host/ipc_video_frame_capturer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/ipc_util.h" 5 #include "remoting/host/ipc_util.h"
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 IPC::Channel::MODE_SERVER, 57 IPC::Channel::MODE_SERVER,
58 listener, 58 listener,
59 io_task_runner); 59 io_task_runner);
60 60
61 // Convert the channel name to the pipe name. 61 // Convert the channel name to the pipe name.
62 std::string pipe_name(kChromePipeNamePrefix); 62 std::string pipe_name(kChromePipeNamePrefix);
63 pipe_name.append(channel_name); 63 pipe_name.append(channel_name);
64 64
65 SECURITY_ATTRIBUTES security_attributes = {0}; 65 SECURITY_ATTRIBUTES security_attributes = {0};
66 security_attributes.nLength = sizeof(security_attributes); 66 security_attributes.nLength = sizeof(security_attributes);
67 security_attributes.lpSecurityDescriptor = NULL; 67 security_attributes.lpSecurityDescriptor = nullptr;
68 security_attributes.bInheritHandle = TRUE; 68 security_attributes.bInheritHandle = TRUE;
69 69
70 // Create the client end of the channel. This code should match the code in 70 // Create the client end of the channel. This code should match the code in
71 // IPC::Channel. 71 // IPC::Channel.
72 base::File client(CreateFile(base::UTF8ToUTF16(pipe_name).c_str(), 72 base::File client(CreateFile(base::UTF8ToUTF16(pipe_name).c_str(),
73 GENERIC_READ | GENERIC_WRITE, 73 GENERIC_READ | GENERIC_WRITE,
74 0, 74 0,
75 &security_attributes, 75 &security_attributes,
76 OPEN_EXISTING, 76 OPEN_EXISTING,
77 SECURITY_SQOS_PRESENT | SECURITY_IDENTIFICATION | 77 SECURITY_SQOS_PRESENT | SECURITY_IDENTIFICATION |
78 FILE_FLAG_OVERLAPPED, 78 FILE_FLAG_OVERLAPPED,
79 NULL)); 79 nullptr));
80 if (!client.IsValid()) { 80 if (!client.IsValid()) {
81 PLOG(ERROR) << "Failed to connect to '" << pipe_name << "'"; 81 PLOG(ERROR) << "Failed to connect to '" << pipe_name << "'";
82 return false; 82 return false;
83 } 83 }
84 84
85 *client_out = client.Pass(); 85 *client_out = client.Pass();
86 *server_out = server.Pass(); 86 *server_out = server.Pass();
87 return true; 87 return true;
88 } 88 }
89 89
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 PLOG(ERROR) 124 PLOG(ERROR)
125 << "Failed to create the server end of the Chromoting IPC channel"; 125 << "Failed to create the server end of the Chromoting IPC channel";
126 return false; 126 return false;
127 } 127 }
128 128
129 *pipe_out = pipe.Pass(); 129 *pipe_out = pipe.Pass();
130 return true; 130 return true;
131 } 131 }
132 132
133 } // namespace remoting 133 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/host/ipc_mouse_cursor_monitor.cc ('k') | remoting/host/ipc_video_frame_capturer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698