Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: remoting/host/gnubby_auth_handler_posix_unittest.cc

Issue 810133003: replace NULL->nullptr in src/remoting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/host/fake_mouse_cursor_monitor.cc ('k') | remoting/host/heartbeat_sender_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_loop.h" 5 #include "base/message_loop/message_loop.h"
6 #include "base/strings/stringprintf.h" 6 #include "base/strings/stringprintf.h"
7 #include "base/timer/mock_timer.h" 7 #include "base/timer/mock_timer.h"
8 #include "net/socket/stream_listen_socket.h" 8 #include "net/socket/stream_listen_socket.h"
9 #include "remoting/host/gnubby_auth_handler_posix.h" 9 #include "remoting/host/gnubby_auth_handler_posix.h"
10 #include "remoting/host/gnubby_socket.h" 10 #include "remoting/host/gnubby_socket.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 EXPECT_CALL(client_stub_, 96 EXPECT_CALL(client_stub_,
97 DeliverHostMessage( 97 DeliverHostMessage(
98 EqualsDataMessage(42, "[116,101,115,116,95,109,115,103]"))); 98 EqualsDataMessage(42, "[116,101,115,116,95,109,115,103]")));
99 99
100 auth_handler_->DeliverHostDataMessage(42, "test_msg"); 100 auth_handler_->DeliverHostDataMessage(42, "test_msg");
101 } 101 }
102 102
103 TEST_F(GnubbyAuthHandlerPosixTest, DidClose) { 103 TEST_F(GnubbyAuthHandlerPosixTest, DidClose) {
104 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_); 104 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_);
105 105
106 delegate_->DidAccept(NULL, make_scoped_ptr(socket)); 106 delegate_->DidAccept(nullptr, make_scoped_ptr(socket));
107 ASSERT_TRUE(auth_handler_posix_->HasActiveSocketForTesting(socket)); 107 ASSERT_TRUE(auth_handler_posix_->HasActiveSocketForTesting(socket));
108 108
109 delegate_->DidClose(socket); 109 delegate_->DidClose(socket);
110 ASSERT_FALSE(auth_handler_posix_->HasActiveSocketForTesting(socket)); 110 ASSERT_FALSE(auth_handler_posix_->HasActiveSocketForTesting(socket));
111 } 111 }
112 112
113 TEST_F(GnubbyAuthHandlerPosixTest, DidRead) { 113 TEST_F(GnubbyAuthHandlerPosixTest, DidRead) {
114 EXPECT_CALL(client_stub_, DeliverHostMessage(_)); 114 EXPECT_CALL(client_stub_, DeliverHostMessage(_));
115 115
116 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_); 116 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_);
117 117
118 delegate_->DidAccept(NULL, make_scoped_ptr(socket)); 118 delegate_->DidAccept(nullptr, make_scoped_ptr(socket));
119 delegate_->DidRead(socket, 119 delegate_->DidRead(socket,
120 reinterpret_cast<const char*>(request_data), 120 reinterpret_cast<const char*>(request_data),
121 sizeof(request_data)); 121 sizeof(request_data));
122 } 122 }
123 123
124 TEST_F(GnubbyAuthHandlerPosixTest, DidReadByteByByte) { 124 TEST_F(GnubbyAuthHandlerPosixTest, DidReadByteByByte) {
125 EXPECT_CALL(client_stub_, DeliverHostMessage(_)); 125 EXPECT_CALL(client_stub_, DeliverHostMessage(_));
126 126
127 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_); 127 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_);
128 128
129 delegate_->DidAccept(NULL, make_scoped_ptr(socket)); 129 delegate_->DidAccept(nullptr, make_scoped_ptr(socket));
130 for (unsigned int i = 0; i < sizeof(request_data); ++i) { 130 for (unsigned int i = 0; i < sizeof(request_data); ++i) {
131 delegate_->DidRead( 131 delegate_->DidRead(
132 socket, reinterpret_cast<const char*>(request_data + i), 1); 132 socket, reinterpret_cast<const char*>(request_data + i), 1);
133 } 133 }
134 } 134 }
135 135
136 TEST_F(GnubbyAuthHandlerPosixTest, DidReadTimeout) { 136 TEST_F(GnubbyAuthHandlerPosixTest, DidReadTimeout) {
137 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_); 137 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_);
138 138
139 delegate_->DidAccept(NULL, make_scoped_ptr(socket)); 139 delegate_->DidAccept(nullptr, make_scoped_ptr(socket));
140 ASSERT_TRUE(auth_handler_posix_->HasActiveSocketForTesting(socket)); 140 ASSERT_TRUE(auth_handler_posix_->HasActiveSocketForTesting(socket));
141 141
142 base::MockTimer* mock_timer = new base::MockTimer(false, false); 142 base::MockTimer* mock_timer = new base::MockTimer(false, false);
143 auth_handler_posix_->GetGnubbySocketForTesting(socket) 143 auth_handler_posix_->GetGnubbySocketForTesting(socket)
144 ->SetTimerForTesting(make_scoped_ptr(mock_timer)); 144 ->SetTimerForTesting(make_scoped_ptr(mock_timer));
145 delegate_->DidRead(socket, reinterpret_cast<const char*>(request_data), 1); 145 delegate_->DidRead(socket, reinterpret_cast<const char*>(request_data), 1);
146 mock_timer->Fire(); 146 mock_timer->Fire();
147 147
148 ASSERT_FALSE(auth_handler_posix_->HasActiveSocketForTesting(socket)); 148 ASSERT_FALSE(auth_handler_posix_->HasActiveSocketForTesting(socket));
149 } 149 }
150 150
151 TEST_F(GnubbyAuthHandlerPosixTest, ClientErrorMessageDelivered) { 151 TEST_F(GnubbyAuthHandlerPosixTest, ClientErrorMessageDelivered) {
152 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_); 152 net::StreamListenSocket* socket = new MockStreamListenSocket(delegate_);
153 153
154 delegate_->DidAccept(NULL, make_scoped_ptr(socket)); 154 delegate_->DidAccept(nullptr, make_scoped_ptr(socket));
155 155
156 std::string error_json = base::StringPrintf( 156 std::string error_json = base::StringPrintf(
157 "{\"type\":\"error\",\"connectionId\":%d}", 157 "{\"type\":\"error\",\"connectionId\":%d}",
158 auth_handler_posix_->GetConnectionIdForTesting(socket)); 158 auth_handler_posix_->GetConnectionIdForTesting(socket));
159 159
160 ASSERT_TRUE(auth_handler_posix_->HasActiveSocketForTesting(socket)); 160 ASSERT_TRUE(auth_handler_posix_->HasActiveSocketForTesting(socket));
161 auth_handler_->DeliverClientMessage(error_json); 161 auth_handler_->DeliverClientMessage(error_json);
162 ASSERT_FALSE(auth_handler_posix_->HasActiveSocketForTesting(socket)); 162 ASSERT_FALSE(auth_handler_posix_->HasActiveSocketForTesting(socket));
163 } 163 }
164 164
165 } // namespace remoting 165 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/host/fake_mouse_cursor_monitor.cc ('k') | remoting/host/heartbeat_sender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698