ash/wm/overview/scoped_transform_overview_window.cc - Issue 810033010: Remove TransparentActivateWindowButton from Overview Mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/overview/scoped_transform_overview_window.cc

Issue 810033010: Remove TransparentActivateWindowButton from Overview Mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Took care of comments, now windows are selected in click release Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/overview/scoped_transform_overview_window.h ('k') | ash/wm/overview/transparent_activate_window_button.h » ('j') | ash/wm/overview/window_selector_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/overview/scoped_transform_overview_window.cc

diff --git a/ash/wm/overview/scoped_transform_overview_window.cc b/ash/wm/overview/scoped_transform_overview_window.cc

index 5d2734d21acd59045003906424133a33e22bc221..a3ebe83cf2cbab43f440fcfd09f3d0b869e4ea20 100644

--- a/ash/wm/overview/scoped_transform_overview_window.cc

+++ b/ash/wm/overview/scoped_transform_overview_window.cc

@@ -166,8 +166,6 @@ TransientDescendantIteratorRange GetTransientTreeIterator(

ScopedTransformOverviewWindow::ScopedTransformOverviewWindow(

aura::Window* window)

: window_(window),

- activate_button_(new TransparentActivateWindowButton(

- window_->GetRootWindow(), this)),

minimized_(window->GetProperty(aura::client::kShowStateKey) ==

ui::SHOW_STATE_MINIMIZED),

ignored_by_shelf_(wm::GetWindowState(window)->ignored_by_shelf()),

@@ -304,10 +302,6 @@ void ScopedTransformOverviewWindow::SetOpacity(float opacity) {

}

-void ScopedTransformOverviewWindow::Select() {

- wm::GetWindowState(window_)->Activate();

void ScopedTransformOverviewWindow::Close() {

aura::Window* window = GetTransientRoot(window_);

views::Widget::GetWidgetForNativeView(window)->Close();