ash/wm/panels/panel_window_event_handler.cc - Issue 810033010: Remove TransparentActivateWindowButton from Overview Mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/panels/panel_window_event_handler.cc

Issue 810033010: Remove TransparentActivateWindowButton from Overview Mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/wm/overview/window_selector_unittest.cc ('K') | « ash/wm/overview/window_selector_unittest.cc ('k') | ash/wm/workspace/workspace_event_handler.cc » ('j') | ash/wm/workspace/workspace_event_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/panels/panel_window_event_handler.cc

diff --git a/ash/wm/panels/panel_window_event_handler.cc b/ash/wm/panels/panel_window_event_handler.cc

index 006c5d89ef7a7d8e4e1c1f7a6cdaa3829952dc25..36b0bd587a4ee307614c6f9243b00b6eeb989f2a 100644

--- a/ash/wm/panels/panel_window_event_handler.cc

+++ b/ash/wm/panels/panel_window_event_handler.cc

@@ -26,6 +26,7 @@ void PanelWindowEventHandler::OnMouseEvent(ui::MouseEvent* event) {

event->type() == ui::ET_MOUSE_PRESSED &&

event->flags() & ui::EF_IS_DOUBLE_CLICK &&

event->IsOnlyLeftMouseButton() &&

+ target->delegate() &&

Nina 2015/01/09 15:43:49 Without this change, this code crashed when handli

target->delegate()->GetNonClientComponent(event->location()) ==

HTCAPTION) {

ash::Shell::GetInstance()->metrics()->RecordUserMetricsAction(

@@ -41,6 +42,7 @@ void PanelWindowEventHandler::OnGestureEvent(ui::GestureEvent* event) {

if (!event->handled() &&

event->type() == ui::ET_GESTURE_TAP &&

event->details().tap_count() == 2 &&

+ target->delegate() &&

Nina 2015/01/09 15:43:49 Same as L29

target->delegate()->GetNonClientComponent(event->location()) ==

HTCAPTION) {

ash::Shell::GetInstance()->metrics()->RecordUserMetricsAction(