Issue 810033005: Initialize TextEncoding singletons in a threadsafe manner.

Issue 810033005: Initialize TextEncoding singletons in a threadsafe manner. (Closed)

Created:
5 years, 11 months ago by sof

Modified:
5 years, 11 months ago

Reviewers:
haraken, jochen (gone - plz use gerrit)

CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Initialize TextEncoding singletons in a threadsafe manner. R=haraken,jochen BUG=445481 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188041

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	Source/wtf/text/TextEncoding.cpp	View		3 chunks	+10 lines, -9 lines	0 comments	Download

Total messages: 8 (2 generated)

sof

Please take a look. As encountered by TSan; have uses of AtomicallyInitializedStatic() previously caused perf ...

5 years, 11 months ago (2015-01-08 10:57:40 UTC) #2

sof

On 2015/01/08 11:09:14, haraken wrote: > LGTM, though I'm not an owner of wtf/. jochen@: ...

5 years, 11 months ago (2015-01-08 12:29:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810033005/1

5 years, 11 months ago (2015-01-08 13:16:53 UTC) #7

commit-bot: I haz the power

5 years, 11 months ago (2015-01-08 13:20:45 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188041