debugger: Remove few redundant variables

debugger: Remove few redundant variables

Use the GUI widget states instead of instance variables
reflecting the widget state.

Fixes the case where pause state would be left on when
switching files, but the image would change to the last
frame of newly loaded image.

Committed: https://skia.googlesource.com/skia/+/f3a9e993399fcb8dae4bf6f1dd9674a72b289da3

[Kimmo Kinnunen, 2015-01-02 14:11:48]

kkinnunen@nvidia.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-01-02 14:51:46]

lgtm + nits

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cpp
File debugger/QT/SkDebuggerGUI.cpp (right):

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:132: list->setIndexStyle(indexStyleToggle ?
SkListWidget::kOffset_IndexStyle :
Move the ':' down and line this up with the '?' ?

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:220: }
this-> ?

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:253: 
this-> ?

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:411: if (currentRow != -1) {
this-> ?

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:437: void SkDebuggerGUI::selectCommand(int
command) {
this-> ?

[Kimmo Kinnunen, 2015-01-05 09:04:22]

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cpp
File debugger/QT/SkDebuggerGUI.cpp (right):

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:132: list->setIndexStyle(indexStyleToggle ?
SkListWidget::kOffset_IndexStyle :
On 2015/01/02 14:51:46, robertphillips wrote:
> Move the ':' down and line this up with the '?' ?

Done.

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:220: }
On 2015/01/02 14:51:46, robertphillips wrote:
> this-> ?

Done.

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:253: 
On 2015/01/02 14:51:46, robertphillips wrote:
> this-> ?

Done.

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:411: if (currentRow != -1) {
On 2015/01/02 14:51:46, robertphillips wrote:
> this-> ?

Done.

https://codereview.chromium.org/810033004/diff/1/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:437: void SkDebuggerGUI::selectCommand(int
command) {
On 2015/01/02 14:51:46, robertphillips wrote:
> this-> ?

Done.

[Kimmo Kinnunen, 2015-01-05 09:04:26]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-01-05 09:05:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/810033004/20001

[commit-bot: I haz the power, 2015-01-05 09:14:14]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f3a9e993399fcb8dae4bf6f1dd9674a72b289da3