Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 810023003: [WebCrypto] Check for OperationError instead of NotSupportedError (Closed)

Created:
6 years ago by Habib Virji
Modified:
6 years ago
Reviewers:
eroman, pgervais
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WebCrypto] Check for OperationError instead of NotSupportedError Test updated in ecdh and rsa to match with chromium side changes - Throw OperationError instead of NotSupportedError when AES length is 192 and RSA modulus is unsupported R=eroman BUG=441877 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187503

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved to common place for crypto tests #

Total comments: 2

Patch Set 3 : Updated TestExpectations #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/crypto/ecdh-deriveKey-failures-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/crypto/rsa-ssa-generateKey-parseAlgorithm-failures-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
eroman
https://codereview.chromium.org/810023003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/810023003/diff/1/LayoutTests/TestExpectations#newcode1230 LayoutTests/TestExpectations:1230: crbug.com/441877 [ Win Mac ] crypto/ecdh-deriveKey-failures.html [ Failure Pass ...
6 years ago (2014-12-18 20:43:37 UTC) #1
Habib Virji
Updated. https://codereview.chromium.org/810023003/diff/1/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/810023003/diff/1/LayoutTests/TestExpectations#newcode1230 LayoutTests/TestExpectations:1230: crbug.com/441877 [ Win Mac ] crypto/ecdh-deriveKey-failures.html [ Failure ...
6 years ago (2014-12-19 00:12:49 UTC) #2
eroman
lgtm https://codereview.chromium.org/810023003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/810023003/diff/20001/LayoutTests/TestExpectations#newcode618 LayoutTests/TestExpectations:618: crbug.com/441877 [ Win Mac ] crypto/ecdh-deriveKey-failures.html [ Failure ...
6 years ago (2014-12-19 00:18:58 UTC) #3
Habib Virji
Updated comment similar to other CL https://codereview.chromium.org/810023003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/810023003/diff/20001/LayoutTests/TestExpectations#newcode618 LayoutTests/TestExpectations:618: crbug.com/441877 [ Win ...
6 years ago (2014-12-19 00:25:36 UTC) #4
eroman
https://codereview.chromium.org/810023003/diff/40001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/810023003/diff/40001/LayoutTests/TestExpectations#newcode617 LayoutTests/TestExpectations:617: # Temporary failure until the chromium-side change land. Same ...
6 years ago (2014-12-19 00:27:36 UTC) #5
Habib Virji
https://codereview.chromium.org/810023003/diff/40001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/810023003/diff/40001/LayoutTests/TestExpectations#newcode617 LayoutTests/TestExpectations:617: # Temporary failure until the chromium-side change land. On ...
6 years ago (2014-12-19 00:29:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810023003/60001
6 years ago (2014-12-19 00:38:57 UTC) #8
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years ago (2014-12-19 02:08:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810023003/60001
6 years ago (2014-12-19 03:39:38 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-19 03:40:46 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187503

Powered by Google App Engine
This is Rietveld 408576698