Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 810013002: [turbofan] simplify gap ordering (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] simplify gap ordering BUG= Committed: https://crrev.com/70b5eb47b39acbf31746f4a116a9b3ce2730218a Cr-Commit-Position: refs/heads/master@{#25865}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -90 lines) Patch
M src/compiler/instruction.h View 4 chunks +3 lines, -31 lines 0 comments Download
M src/compiler/instruction.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/register-allocator.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 3 chunks +13 lines, -34 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
lgtm
6 years ago (2014-12-17 13:10:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810013002/20001
6 years ago (2014-12-17 13:10:52 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-17 13:37:53 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/70b5eb47b39acbf31746f4a116a9b3ce2730218a Cr-Commit-Position: refs/heads/master@{#25865}
6 years ago (2014-12-17 13:38:07 UTC) #6
Michael Achenbach
6 years ago (2014-12-18 14:46:21 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/815743002/ by machenbach@chromium.org.

The reason for reverting is: Revert for breaking emscripten bullet with turbofan
on android arm64..

Powered by Google App Engine
This is Rietveld 408576698