Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8100013: Start off the Content API by moving content::ContentRendererClient to content\public\renderer.BU... (Closed)

Created:
9 years, 2 months ago by jam
Modified:
9 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Start off the Content API by moving content::ContentRendererClient to content\public\renderer. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103609

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 8

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -153 lines) Patch
M chrome/renderer/DEPS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
A content/app/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A content/public/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/public/renderer/content_renderer_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
D content/renderer/content_renderer_client.h View 1 chunk +0 lines, -137 lines 0 comments Download
M content/renderer/mock_content_renderer_client.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webcookiejar_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_renderer_client.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
9 years, 2 months ago (2011-09-30 23:33:49 UTC) #1
Dirk Pranke
http://codereview.chromium.org/8100013/diff/7009/chrome/renderer/DEPS File chrome/renderer/DEPS (right): http://codereview.chromium.org/8100013/diff/7009/chrome/renderer/DEPS#newcode4 chrome/renderer/DEPS:4: "+content/renderer/public", content/public/renderer? http://codereview.chromium.org/8100013/diff/7009/content/content_api.gypi File content/content_api.gypi (right): http://codereview.chromium.org/8100013/diff/7009/content/content_api.gypi#newcode12 content/content_api.gypi:12: } ...
9 years, 2 months ago (2011-10-01 00:24:12 UTC) #2
jam
http://codereview.chromium.org/8100013/diff/7009/chrome/renderer/DEPS File chrome/renderer/DEPS (right): http://codereview.chromium.org/8100013/diff/7009/chrome/renderer/DEPS#newcode4 chrome/renderer/DEPS:4: "+content/renderer/public", On 2011/10/01 00:24:12, Dirk Pranke wrote: > content/public/renderer? ...
9 years, 2 months ago (2011-10-01 00:29:45 UTC) #3
Dirk Pranke
9 years, 2 months ago (2011-10-01 01:19:27 UTC) #4 
On 2011/10/01 00:29:45, John Abd-El-Malek wrote:
> http://codereview.chromium.org/8100013/diff/7009/content/public/OWNERS
> File content/public/OWNERS (right):
> 
>
http://codereview.chromium.org/8100013/diff/7009/content/public/OWNERS#newcode2
> content/public/OWNERS:2: mailto:jam@chromium.org
> On 2011/10/01 00:24:12, Dirk Pranke wrote:
> > we probably want at least two people here ... fishd? me?
> 
> I've done this on purpose; I'd like to review all changes to the API. I think
> one person reviewing all changes, like we have for the WebKit API, will ensure
> that it's consistent.
>

Ok.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698