fpdfsdk/src/javascript/util.cpp - Issue 809993004: Get rid of FX_LPCSTR cast. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1016)

My Issues | Starred Open | Closed | All

Unified Diff: fpdfsdk/src/javascript/util.cpp

Issue 809993004: Get rid of FX_LPCSTR cast. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Indent Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « fpdfsdk/src/javascript/PublicMethods.cpp ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: fpdfsdk/src/javascript/util.cpp

diff --git a/fpdfsdk/src/javascript/util.cpp b/fpdfsdk/src/javascript/util.cpp

index d2813f5083e6f13ceec63ebd987361a236e9a5d9..83fb32cb823f4e0130ffbb21307b0588450ec0d1 100644

--- a/fpdfsdk/src/javascript/util.cpp

+++ b/fpdfsdk/src/javascript/util.cpp

@@ -471,8 +471,8 @@ FX_BOOL util::printx(OBJ_METHOD_PARAMS)

return FALSE;

CFX_WideString sFormat = params[0].operator CFX_WideString();

CFX_WideString sSource = params[1].operator CFX_WideString();

- std::string cFormat = (FX_LPCSTR)CFX_ByteString::FromUnicode(sFormat);

- std::string cSource = (FX_LPCSTR)CFX_ByteString::FromUnicode(sSource);

+ std::string cFormat = CFX_ByteString::FromUnicode(sFormat).c_str();

+ std::string cSource = CFX_ByteString::FromUnicode(sSource).c_str();

std::string cDest;

printx(cFormat,cSource,cDest);

vRet = cDest.c_str();

« no previous file with comments | « fpdfsdk/src/javascript/PublicMethods.cpp ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698