fpdfsdk/src/javascript/JS_Value.cpp - Issue 809993004: Get rid of FX_LPCSTR cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Value.cpp

Issue 809993004: Get rid of FX_LPCSTR cast. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Value.cpp

diff --git a/fpdfsdk/src/javascript/JS_Value.cpp b/fpdfsdk/src/javascript/JS_Value.cpp

index 93da9bea2e144639170c0a4ea6da07133f53493c..cb9768a44ca20a5b47654cf96d8508bbe06ebf28 100644

--- a/fpdfsdk/src/javascript/JS_Value.cpp

+++ b/fpdfsdk/src/javascript/JS_Value.cpp

@@ -400,7 +400,7 @@ void CJS_PropValue::StartGetting()

void CJS_PropValue::operator <<(CFX_ByteString string)

{

ASSERT(!m_bIsSetting);

- CJS_Value::operator =((FX_LPCSTR)string);

+ CJS_Value::operator = (string.c_str());

Tom Sepez 2014/12/30 22:53:26 nit: indent.

}

void CJS_PropValue::operator >>(CFX_ByteString &string) const