fpdfsdk/src/formfiller/FFL_ComboBox.cpp - Issue 809993004: Get rid of FX_LPCSTR cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

Issue 809993004: Get rid of FX_LPCSTR cast. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

diff --git a/fpdfsdk/src/formfiller/FFL_ComboBox.cpp b/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

index ee6b7bd83a18c9644319eb6eb7a2d660419dab56..9e58c952aa45e5787164ca509ba4b5e2325ec176 100644

--- a/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

+++ b/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

@@ -364,7 +364,7 @@ void CFFL_ComboBox::OnSetFocus(CPWL_Wnd* pWnd)

CFX_WideString wsText = pEdit->GetText();

int nCharacters = wsText.GetLength();

CFX_ByteString bsUTFText = wsText.UTF16LE_Encode();

- unsigned short* pBuffer = (unsigned short*)(FX_LPCSTR)bsUTFText;

+ unsigned short* pBuffer = (unsigned short*)bsUTFText.c_str();

m_pApp->FFI_OnSetFieldInputFocus(m_pWidget->GetFormField(), pBuffer, nCharacters, TRUE);

pEdit->SetEditNotify(this);