Get rid of FX_LPCSTR cast.

fpdfsdk/src/jsapi/fxjs_v8.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../core/include/fxcrt/fx_basic.h"
 #include "../../../core/include/fxcrt/fx_ext.h" 
 #include "../../include/jsapi/fxjs_v8.h"
 #include "../../include/fsdk_define.h"
@@ skipping 233 matching lines @@
         v8Context->SetEmbedderData(1, ptr);
 
         CFX_PtrArray* pArray = (CFX_PtrArray*)isolate->GetData(0);
         if(!pArray) return;
 
         for(int i=0; i<pArray->GetSize(); i++)
         {
                 CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(i);
                 CFX_WideString ws = CFX_WideString(pObjDef->objName);
                 CFX_ByteString bs = ws.UTF8Encode();
-                v8::Handle<v8::String> objName = v8::String::NewFromUtf8(isolate,(FX_LPCSTR)bs, v8::String::kNormalString, bs.GetLength());
+        v8::Handle<v8::String> objName = v8::String::NewFromUtf8(isolate, bs.c_str(), v8::String::kNormalString, bs.GetLength());

[brucedawson, 2014/12/30 23:13:02]

Indent, times four in this file.

 
 
                 if(pObjDef->objType == JS_DYNAMIC)
                 {
                         //Document is set as global object, need to construct it first.
                         if(ws.Equal(L"Document"))
                         {
 
                                 CJS_PrivateData* pPrivateData = FX_NEW CJS_PrivateData;
                                 pPrivateData->ObjDefID = i;
@@ skipping 52 matching lines @@
 int JS_Parse(IJS_Runtime* pJSRuntime, IFXJS_Context* pJSContext, const wchar_t* script, long length, FXJSErr* perror)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::TryCatch try_catch;
 
         CFX_WideString wsScript(script);
         CFX_ByteString bsScript = wsScript.UTF8Encode();
 
 
-        v8::Handle<v8::Script> compiled_script = v8::Script::Compile(v8::String::NewFromUtf8(isolate,(FX_LPCSTR)bsScript,v8::String::kNormalString, bsScript.GetLength()));
+    v8::Handle<v8::Script> compiled_script = v8::Script::Compile(v8::String::NewFromUtf8(isolate, bsScript.c_str(), v8::String::kNormalString, bsScript.GetLength()));
         if (compiled_script.IsEmpty()) {
                 v8::String::Utf8Value error(try_catch.Exception());
                 return -1;
         }
         return 0;
 }
 
 int JS_Execute(IJS_Runtime* pJSRuntime, IFXJS_Context* pJSContext, const wchar_t* script, long length, FXJSErr* perror)
 {
         v8::Isolate* isolate = (v8::Isolate*)pJSRuntime;
         v8::Isolate::Scope isolate_scope(isolate);
         v8::TryCatch try_catch;
 
         CFX_WideString wsScript(script);
         CFX_ByteString bsScript = wsScript.UTF8Encode();
 
-        v8::Handle<v8::Script> compiled_script = v8::Script::Compile(v8::String::NewFromUtf8(isolate,(FX_LPCSTR)bsScript,v8::String::kNormalString, bsScript.GetLength()));
+    v8::Handle<v8::Script> compiled_script = v8::Script::Compile(v8::String::NewFromUtf8(isolate, bsScript.c_str(), v8::String::kNormalString, bsScript.GetLength()));
         if (compiled_script.IsEmpty()) {
                 v8::String::Utf8Value error(try_catch.Exception());
                 return -1;
         }
 
         v8::Handle<v8::Value> result = compiled_script->Run();
         if (result.IsEmpty()) {
                 v8::String::Utf8Value error(try_catch.Exception());
                 return -1;
         }
@@ skipping 191 matching lines @@
 v8::Handle<v8::Value> JS_GetObjectValue(v8::Handle<v8::Object> pObj)
 {
         return pObj;
 }
 
 v8::Handle<v8::String> WSToJSString(IJS_Runtime* pJSRuntime, const wchar_t* PropertyName, int Len = -1)
 {
         CFX_WideString ws = CFX_WideString(PropertyName,Len);
         CFX_ByteString bs = ws.UTF8Encode();
         if(!pJSRuntime) pJSRuntime = v8::Isolate::GetCurrent();
-        return v8::String::NewFromUtf8(pJSRuntime, (FX_LPCSTR)bs);
+    return v8::String::NewFromUtf8(pJSRuntime, bs.c_str());
 }
 
 v8::Handle<v8::Value> JS_GetObjectElement(IJS_Runtime* pJSRuntime, v8::Handle<v8::Object> pObj,const wchar_t* PropertyName)
 {
         if(pObj.IsEmpty()) return v8::Handle<v8::Value>();
         return pObj->Get(WSToJSString(pJSRuntime,PropertyName));
 }
 
 v8::Handle<v8::Array> JS_GetObjectElementNames(v8::Handle<v8::Object> pObj)
 {
@@ skipping 464 matching lines @@
 {
         return d != d;
 }
 
 double JS_LocalTime(double d)
 {
         return JS_GetDateTime() + _getDaylightSavingTA(d);
 }
 
 //JavaScript time implement End.