Get rid of FX_LPCSTR cast.

fpdfsdk/src/javascript/PublicMethods.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 425 matching lines @@
 
 
         int ch = ',' ;
         int nIndex = 0;
 
         while (*p)
         {
                 const char * pTemp = strchr(p, ch);
                 if (pTemp == NULL)
                 {
-                        StrArray.SetElement(nIndex, CJS_Value(isolate,(FX_LPCSTR)StrTrim(p)));
+            StrArray.SetElement(nIndex, CJS_Value(isolate, StrTrim(p).c_str()));

[brucedawson, 2014/12/30 23:13:02]

Ditto on the indenting, times four in this file.

                         break;
                 }
                 else
                 {
                         char * pSub = new char[pTemp - p + 1];
                         strncpy(pSub, p, pTemp - p);
                         *(pSub + (pTemp - p)) = '\0';
 
-                        StrArray.SetElement(nIndex, CJS_Value(isolate,(FX_LPCSTR)StrTrim(pSub)));
+            StrArray.SetElement(nIndex, CJS_Value(isolate, StrTrim(pSub).c_str()));
                         delete []pSub;
                         
                         nIndex ++;
                         p = ++pTemp;
                 }
                 
         }
         return StrArray;
 }
 
@@ skipping 1334 matching lines @@
 
         std::string cFormat;
         int iIndex = params[0];
 
         CJS_EventHandler* pEvent = pContext->GetEventHandler();
         ASSERT(pEvent != NULL);
 
         if(!pEvent->m_pValue)
                 return FALSE;
         CFX_WideString& Value = pEvent->Value();        
-        std::string strSrc = (FX_LPCSTR)CFX_ByteString::FromUnicode(Value);
+    std::string strSrc = CFX_ByteString::FromUnicode(Value).c_str();
         
         switch (iIndex) 
         {
         case 0:                         
                 cFormat = "99999";
                 break;
         case 1:                         
                 cFormat = "99999-9999";
                 break;
         case 2:                         
@@ skipping 134 matching lines @@
                 return FALSE;
         }
 
         std::string cFormat;
         int iIndex = (int)params[0];    
 
         if(!pEvent->m_pValue)
                 return FALSE;
         //CJS_Value val = pEvent->Value();
         CFX_WideString& val = pEvent->Value();
-        std::string strSrc = (FX_LPCSTR)CFX_ByteString::FromUnicode(val);
+    std::string strSrc = CFX_ByteString::FromUnicode(val).c_str();
         std::wstring wstrChange(pEvent->Change());
         
         switch (iIndex) 
         {
         case 0:                         
                 cFormat = "99999";
                 break;
         case 1:                         
                 //cFormat = "99999-9999";
                 cFormat = "999999999";
@@ skipping 340 matching lines @@
                 nums.SetElement(nIndex,CJS_Value(isolate,sPart.c_str()));       
         }
 
         if (nums.GetLength() > 0)
                 vRet = nums;
         else
                 vRet.SetNull();
 
         return TRUE;
 }