Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 809903009: Fix NativeWidgetMacTest.HideAndShowExternally (Closed)

Created:
6 years ago by tapted
Modified:
6 years ago
Reviewers:
Andre
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NativeWidgetMacTest.HideAndShowExternally This regressed in r308886 because the unit test changed from having no activation policy to having a "Regular" activation policy. With a regular activation policy, calls to [NSApp hide/show*:] are asynchronous, so the run loop needs to be flushed afterwards. Also adds an extra check for [NSWindow makeKeyAndOrderFront:]. It doesn't need a runloop flush for the visibility change, but it should have coverage anyway. BUG=378134 Committed: https://crrev.com/bc8f60252ea3b2a1d53cd058c32ae99d8d1d0ad8 Cr-Commit-Position: refs/heads/master@{#309478}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M ui/views/widget/native_widget_mac_unittest.mm View 1 3 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tapted
Hi Andre, please take a look.
6 years ago (2014-12-22 10:41:04 UTC) #2
Andre
lgtm https://codereview.chromium.org/809903009/diff/1/ui/views/widget/native_widget_mac_unittest.mm File ui/views/widget/native_widget_mac_unittest.mm (right): https://codereview.chromium.org/809903009/diff/1/ui/views/widget/native_widget_mac_unittest.mm#newcode92 ui/views/widget/native_widget_mac_unittest.mm:92: // calls superfluous, but don't hurt. calls are ...
6 years ago (2014-12-22 19:31:00 UTC) #3
tapted
https://codereview.chromium.org/809903009/diff/1/ui/views/widget/native_widget_mac_unittest.mm File ui/views/widget/native_widget_mac_unittest.mm (right): https://codereview.chromium.org/809903009/diff/1/ui/views/widget/native_widget_mac_unittest.mm#newcode92 ui/views/widget/native_widget_mac_unittest.mm:92: // calls superfluous, but don't hurt. On 2014/12/22 19:31:00, ...
6 years ago (2014-12-22 21:58:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809903009/20001
6 years ago (2014-12-22 21:59:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-22 22:52:28 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 22:54:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc8f60252ea3b2a1d53cd058c32ae99d8d1d0ad8
Cr-Commit-Position: refs/heads/master@{#309478}

Powered by Google App Engine
This is Rietveld 408576698