Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 809903005: ui/views: Cleanup usage of scoped_ptr. (Closed)

Created:
6 years ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, dcheng, Ben Goodger (Google), danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/views: Cleanup usage of scoped_ptr. * Return nullptr whenever possible. * Use make_scoped_ptr() when possible (less typing/noise). Entries found with the following command line: $ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)' ui/views BUG=None R=sky@chromium.org Committed: https://crrev.com/c999097cef4e2ae05ed554bbc4b85d64928c992d Cr-Commit-Position: refs/heads/master@{#310603}

Patch Set 1 #

Total comments: 8

Patch Set 2 : no need of Pass() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M ui/views/border.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/event_monitor_aura.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/event_monitor_mac.mm View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/painter.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/test/event_generator_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater_auralinux.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
PTAL
6 years ago (2014-12-20 18:49:36 UTC) #1
sky
LGTM with the extra .Pass()s removed. https://codereview.chromium.org/809903005/diff/1/ui/views/painter.cc File ui/views/painter.cc (right): https://codereview.chromium.org/809903005/diff/1/ui/views/painter.cc#newcode275 ui/views/painter.cc:275: return make_scoped_ptr(new DashedFocusPainter(gfx::Insets())).Pass(); ...
5 years, 11 months ago (2015-01-05 17:45:05 UTC) #2
tfarina
https://codereview.chromium.org/809903005/diff/1/ui/views/painter.cc File ui/views/painter.cc (right): https://codereview.chromium.org/809903005/diff/1/ui/views/painter.cc#newcode275 ui/views/painter.cc:275: return make_scoped_ptr(new DashedFocusPainter(gfx::Insets())).Pass(); On 2015/01/05 17:45:04, sky wrote: > ...
5 years, 11 months ago (2015-01-08 20:43:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809903005/20001
5 years, 11 months ago (2015-01-08 20:45:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 21:35:03 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 21:35:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c999097cef4e2ae05ed554bbc4b85d64928c992d
Cr-Commit-Position: refs/heads/master@{#310603}

Powered by Google App Engine
This is Rietveld 408576698