Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 809883004: Revert hardware decoder changes causing ChromeOS HW test crash. (Closed)

Created:
5 years, 11 months ago by rkc
Modified:
5 years, 11 months ago
Reviewers:
Pawel Osciak
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, darin (slow to review), miu+watch_chromium.org, marcheu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert hardware decoder changes causing ChromeOS HW test crash. This CL reverts three CLs suspected of causing http://crbug.com/446890 After the three CLs are reverted, the test passes again. Revert "V4L2VDA: Generalize EGLImage import and query driver for output formats." This reverts commit 3b87d51779440abedbf5fd0578b7ea02b988d876. Revert "V4L2VDA: Fix format initialization order." This reverts commit c5c56aed4d336726d6059dcb0a40101459d3703a. Revert "V4L2VDA/vdaunittest: Allow VP9 format if supported." This reverts commit 47a93b8dfc17ac9d2fc7d6a2886a571dce2539c7. TBR=posciak@chromium.org BUG=446890 Committed: https://chromium.googlesource.com/chromium/src/+/81e7e3b6e6cdcf506a8ede4c2e36a35b582d010f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -321 lines) Patch
M cc/resources/video_resource_updater.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/media/generic_v4l2_video_device.h View 1 chunk +22 lines, -23 lines 0 comments Download
M content/common/gpu/media/generic_v4l2_video_device.cc View 4 chunks +32 lines, -79 lines 0 comments Download
M content/common/gpu/media/tegra_v4l2_video_device.h View 1 chunk +22 lines, -23 lines 0 comments Download
M content/common/gpu/media/tegra_v4l2_video_device.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.h View 3 chunks +1 line, -7 lines 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.cc View 9 chunks +36 lines, -75 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.h View 4 chunks +4 lines, -7 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.cc View 4 chunks +0 lines, -30 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M media/base/video_frame.h View 2 chunks +1 line, -4 lines 0 comments Download
M media/base/video_frame.cc View 10 chunks +14 lines, -44 lines 0 comments Download
M media/blink/video_frame_compositor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/skcanvas_video_renderer.cc View 4 chunks +1 line, -4 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rkc
5 years, 11 months ago (2015-01-07 21:20:11 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/81e7e3b6e6cdcf506a8ede4c2e36a35b582d010f Cr-Commit-Position: refs/heads/master@{#310369}
5 years, 11 months ago (2015-01-07 21:22:31 UTC) #2
rkc
5 years, 11 months ago (2015-01-07 21:22:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81e7e3b6e6cdcf506a8ede4c2e36a35b582d010f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698