Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809833002: string_number_conversions: only check CXX_LIBRARY_HAS_CONSTEXPR (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

string_number_conversions: only check CXX_LIBRARY_HAS_CONSTEXPR. CXX_LIBRARY_VERSION is irrelevant, because the only C++11 library feature of any concern is whether numeric_limits’ min() and max() are declared constexpr. Crashpad is C++11-only as far as the language is concerned, and the comment doesn’t need to call it out explicitly because static_assert() is always available. R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5adfa5039ef31c8f2baf5f940145cb32325842a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M util/stdlib/string_number_conversion.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-12-16 19:29:03 UTC) #2
scottmg
lgtm
6 years ago (2014-12-16 19:41:20 UTC) #3
Mark Mentovai
6 years ago (2014-12-16 19:55:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5adfa5039ef31c8f2baf5f940145cb32325842a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698