Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809823002: replace COMPILE_ASSERT with static assert in core/css/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static assert in core/css/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/css/CSSBasicShapes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSRule.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mostyn Bramley-Moore
@rune: PTAL.
6 years ago (2014-12-16 19:21:11 UTC) #2
rune
lgtm
6 years ago (2014-12-16 20:45:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809823002/1
6 years ago (2014-12-16 21:10:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42150)
6 years ago (2014-12-16 23:05:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809823002/1
6 years ago (2014-12-16 23:08:31 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-17 00:23:29 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187305

Powered by Google App Engine
This is Rietveld 408576698