Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 809803006: Gallery: Add debugMe method to Gallery. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Add debugMe method to Gallery. The CL adds debug mode to check the load target in mosaic mode. BUG=427815 TEST=None Committed: https://crrev.com/03a484613d6f9d6ba12082f6e0c452fac6fff1b7 Cr-Commit-Position: refs/heads/master@{#311206}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add missing unittests. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -10 lines) Patch
M chrome/browser/chromeos/file_manager/gallery_jstest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 1 chunk +25 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 3 chunks +31 lines, -0 lines 0 comments Download
A + ui/file_manager/gallery/js/mosaic_mode_unittest.html View 1 1 chunk +8 lines, -10 lines 0 comments Download
A ui/file_manager/gallery/js/mosaic_mode_unittest.js View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thanks!
5 years, 11 months ago (2015-01-09 11:08:43 UTC) #2
fukino
lgtm with a nit. https://codereview.chromium.org/809803006/diff/1/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/809803006/diff/1/ui/file_manager/gallery/js/gallery.js#newcode913 ui/file_manager/gallery/js/gallery.js:913: * Entres the debug mode. ...
5 years, 11 months ago (2015-01-09 11:29:03 UTC) #3
hirono
Thanks! https://codereview.chromium.org/809803006/diff/1/ui/file_manager/gallery/js/gallery.js File ui/file_manager/gallery/js/gallery.js (right): https://codereview.chromium.org/809803006/diff/1/ui/file_manager/gallery/js/gallery.js#newcode913 ui/file_manager/gallery/js/gallery.js:913: * Entres the debug mode. On 2015/01/09 11:29:03, ...
5 years, 11 months ago (2015-01-13 03:13:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809803006/40001
5 years, 11 months ago (2015-01-13 03:13:54 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-13 04:17:14 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 04:18:11 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/03a484613d6f9d6ba12082f6e0c452fac6fff1b7
Cr-Commit-Position: refs/heads/master@{#311206}

Powered by Google App Engine
This is Rietveld 408576698