Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 809803003: Oilpan: non-eagerly trace HTML element stack records. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: non-eagerly trace HTML element stack records. For some parses, the ElementRecord chains kept by the HTML element parse stack might end up very long, requiring corresponding amounts of call stack when being traced eagerly. Use the marking stack instead for these objects, as is done for the ContainerNodes these record objects refer to. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/html/parser/HTMLElementStack.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. Trace depth assert triggered on the bots, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpan__dbg_/4762/layout-test-results/fast/parser/residual-style-hang-crash-log.txt (I bet it ...
5 years, 11 months ago (2014-12-31 07:36:30 UTC) #2
haraken
LGTM
5 years, 11 months ago (2014-12-31 13:01:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809803003/1
5 years, 11 months ago (2014-12-31 13:24:31 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2014-12-31 14:46:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187808

Powered by Google App Engine
This is Rietveld 408576698